Page MenuHomePhabricator
Differential D3126

[web] [refactor] thread-list-sidebar, active thread style to use classnames lib instead of ternary
ClosedPublic
Actions

Authored by • benschac on Feb 7 2022, 8:42 AM.
Tags
None
Referenced Files
F3315142: D3126.diff
Tue, Nov 19, 3:07 PM
Unknown Object (File)
Sat, Nov 2, 4:05 AM
Unknown Object (File)
Sat, Nov 2, 4:05 AM
Unknown Object (File)
Sat, Nov 2, 4:04 AM
Unknown Object (File)
Sat, Nov 2, 3:59 AM
Unknown Object (File)
Thu, Oct 24, 11:59 PM
Unknown Object (File)
Thu, Oct 24, 11:59 PM
Unknown Object (File)
Thu, Oct 24, 11:58 PM
View All 92 Files
Subscribers
• adrian
ashoat
• karol
tomek

Details

Reviewers
atul
ashoat
Commits
rCOMM891b4d0f11f0: [web] [refactor] thread-list-sidebar, active thread style to use classnames lib…
Summary

use the classnames library rather than ternary.

Test Plan

Make sure active class still renders.

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• benschac created this revision.Feb 7 2022, 8:42 AM
Herald added subscribers: • karol, • adrian, tomek, ashoat. · View Herald TranscriptFeb 7 2022, 8:42 AM
Harbormaster completed remote builds in B6597: Diff 9353.Feb 7 2022, 8:47 AM
• benschac requested review of this revision.Feb 7 2022, 8:47 AM
ashoat accepted this revision.Feb 7 2022, 7:27 PM
ashoat added inline comments.
web/chat/chat-thread-list-sidebar.react.js
23–27

Personally, this just looks icky to me. I would pull out the property declaration into a separate line in front of the JSX. The fact that it doesn't change the indentation level of the enclosed block makes it more okay though

This revision is now accepted and ready to land.Feb 7 2022, 7:27 PM
Closed by commit rCOMM891b4d0f11f0: [web] [refactor] thread-list-sidebar, active thread style to use classnames lib… (authored by • benschac). · Explain WhyFeb 9 2022, 6:55 AM
This revision was automatically updated to reflect the committed changes.
• benschac added a commit: rCOMM891b4d0f11f0: [web] [refactor] thread-list-sidebar, active thread style to use classnames lib….

Revision Contents
Changeset List

PathSize
web/
chat/
8 lines

Diff 9353

View Options

web/chat/chat-thread-list-sidebar.react.js

Loading...