Page MenuHomePhabricator
Differential D3127

[CommCoreModule] Add `endpoint: string` arg to `CommCoreModule.openSocket()`
ClosedPublic
Actions

Authored by atul on Feb 7 2022, 10:07 AM.
Tags
None
Referenced Files
Unknown Object (File)
Nov 10 2024, 11:56 PM
Unknown Object (File)
Nov 10 2024, 11:56 PM
Unknown Object (File)
Nov 10 2024, 11:56 PM
Unknown Object (File)
Nov 10 2024, 11:11 PM
Unknown Object (File)
Nov 5 2024, 12:50 AM
Unknown Object (File)
Oct 24 2024, 11:59 PM
Unknown Object (File)
Oct 24 2024, 11:59 PM
Unknown Object (File)
Oct 24 2024, 11:59 PM
View All Files
Subscribers
• adrian
• benschac
tomek

Details

Reviewers
ashoat
varun
• jacek
• karol
• jim
Commits
rCOMM94cccc829268: [CommCoreModule] Add `endpoint: string` arg to `CommCoreModule.openSocket()`
Summary

Right now we're just hardcoding in localhost

[ignore: D3125]

Test Plan

Haven't tested with anything other than localhost... but continues to build/work as expected

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Feb 7 2022, 10:07 AM
Herald added subscribers: • benschac, • adrian, tomek. · View Herald TranscriptFeb 7 2022, 10:07 AM
Harbormaster completed remote builds in B6598: Diff 9354.Feb 7 2022, 10:17 AM
atul requested review of this revision.Feb 7 2022, 10:17 AM
atul edited the summary of this revision. (Show Details)Feb 7 2022, 11:31 AM
atul added a parent revision: D3125: [CommCoreModule] Add `openSocket` to `CommCoreModuleSchema`.
atul edited the summary of this revision. (Show Details)
ashoat accepted this revision.Feb 7 2022, 7:30 PM
ashoat added a reviewer: • jim.
This revision is now accepted and ready to land.Feb 7 2022, 7:30 PM
atul updated this revision to Diff 9385.Feb 8 2022, 5:26 AM

rebase before landing

This revision was landed with ongoing or failed builds.Feb 8 2022, 5:27 AM
Closed by commit rCOMM94cccc829268: [CommCoreModule] Add `endpoint: string` arg to `CommCoreModule.openSocket()` (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM94cccc829268: [CommCoreModule] Add `endpoint: string` arg to `CommCoreModule.openSocket()`.
Harbormaster completed remote builds in B6622: Diff 9385.Feb 8 2022, 5:31 AM

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
NativeModules/
3 lines
3 lines
_generated/
schema/
2 lines

Diff 9386

View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.h

Loading...
View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

Loading...
View Options

native/cpp/CommonCpp/_generated/NativeModules.h

Loading...
View Options

native/cpp/CommonCpp/_generated/NativeModules.cpp

Loading...
View Options

native/schema/CommCoreModuleSchema.js

Loading...