Page MenuHomePhabricator
Differential D3144

[CommCoreModule] Fill out `newSession(...) => sessionID` boilerplate in `Client`
ClosedPublic
Actions

Authored by atul on Feb 8 2022, 1:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 2, 7:08 AM
Unknown Object (File)
Fri, Oct 25, 12:01 AM
Unknown Object (File)
Fri, Oct 25, 12:01 AM
Unknown Object (File)
Fri, Oct 25, 12:01 AM
Unknown Object (File)
Fri, Oct 25, 12:01 AM
Unknown Object (File)
Fri, Oct 25, 12:01 AM
Unknown Object (File)
Oct 7 2024, 10:19 AM
Unknown Object (File)
Oct 7 2024, 10:19 AM
View All Files
Subscribers
• adrian
• benschac

Details

Reviewers
ashoat
• jacek
tomek
varun
• karol
• jim
Commits
rCOMMb0280f92d3ba: [CommCoreModule] Fill out `newSession(...) => sessionID` boilerplate in `Client`
Summary

So we can hit NewSession(...) endpoint

Test Plan

Hit tunnelbroker with request and see if we get a response

Diff Detail

Repository
rCOMM Comm
Branch
landfeb8 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Feb 8 2022, 1:44 PM
Herald added subscribers: • benschac, • adrian. · View Herald TranscriptFeb 8 2022, 1:44 PM
atul published this revision for review.Feb 8 2022, 1:45 PM
Harbormaster failed remote builds in B6652: Diff 9417!Feb 8 2022, 1:46 PM
atul updated this revision to Diff 9418.Feb 8 2022, 2:39 PM

fix

Harbormaster failed remote builds in B6653: Diff 9418!Feb 8 2022, 2:41 PM
varun accepted this revision.Feb 8 2022, 2:43 PM
This revision is now accepted and ready to land.Feb 8 2022, 2:43 PM
Herald added 1 blocking reviewer(s): ashoat. · View Herald TranscriptFeb 8 2022, 2:43 PM
This revision now requires review to proceed.Feb 8 2022, 2:43 PM
ashoat accepted this revision.Feb 8 2022, 9:41 PM
ashoat added a reviewer: • jim.

Same question as in D3143

This revision is now accepted and ready to land.Feb 8 2022, 9:41 PM
atul updated this revision to Diff 9480.Feb 9 2022, 10:16 AM

replace NULL with empty string

Harbormaster completed remote builds in B6688: Diff 9480.Feb 9 2022, 10:23 AM
atul updated this revision to Diff 9483.Feb 9 2022, 10:32 AM

rebase before landing

This revision was landed with ongoing or failed builds.Feb 9 2022, 10:34 AM
Closed by commit rCOMMb0280f92d3ba: [CommCoreModule] Fill out `newSession(...) => sessionID` boilerplate in `Client` (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMMb0280f92d3ba: [CommCoreModule] Fill out `newSession(...) => sessionID` boilerplate in `Client`.
Harbormaster completed remote builds in B6690: Diff 9483.Feb 9 2022, 10:45 AM

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
grpc/
9 lines
27 lines

Diff 9417

View Options

native/cpp/CommonCpp/grpc/Client.h

Loading...
View Options

native/cpp/CommonCpp/grpc/Client.cpp

Loading...