[services] Backup - Fix CI
ClosedPublic
Actions

Authored by • karol on Feb 9 2022, 3:04 AM.

Details

Reviewers

tomek
ashoat
• max

Commits

rCOMM53338aba277a: [services] Backup - Fix CI

Summary

This fixes the CI that was broken because of mistakenly landed diffs for the new backup version.
First, we have to finish the arch design D2950
Then we need to update proto files D3076

Until these two diffs are not landed, we may land this quick fix just to unblock the CI

Test Plan

cd services
yarn run-backup-service

Diff Detail

Repository

rCOMM Comm

Branch

fix-ci-backup

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• karol created this revision.Feb 9 2022, 3:04 AM

Herald added subscribers: atul, • adrian, tomek, ashoat. · View Herald TranscriptFeb 9 2022, 3:04 AM

• karol edited the summary of this revision. (Show Details)Feb 9 2022, 3:08 AM

• karol edited the test plan for this revision. (Show Details)

• karol added reviewers: tomek, ashoat, • max.

Herald added a subscriber: • benschac. · View Herald TranscriptFeb 9 2022, 3:08 AM

• karol published this revision for review.Feb 9 2022, 3:09 AM

Harbormaster completed remote builds in B6665: Diff 9436.Feb 9 2022, 3:09 AM

tomek accepted this revision.Feb 9 2022, 3:32 AM

This revision is now accepted and ready to land.Feb 9 2022, 3:32 AM

Herald added 1 blocking reviewer(s): ashoat. · View Herald TranscriptFeb 9 2022, 3:32 AM

This revision now requires review to proceed.Feb 9 2022, 3:32 AM

If possible, I would rather comment out the tests or whatevever is crashing. But the important thing is to fix the CI ASAP

This revision is now accepted and ready to land.Feb 9 2022, 6:43 AM

This exact change is crashing because it's out of sync with the proto file.
The proto file is not landed because it waits for the arch review.

I'm going to land this, we can always revert but I think this should do the trick and will not be harmful.

Closed by commit rCOMM53338aba277a: [services] Backup - Fix CI (authored by • karol). · Explain WhyFeb 9 2022, 6:49 AM

This revision was automatically updated to reflect the committed changes.

• karol added a commit: rCOMM53338aba277a: [services] Backup - Fix CI.

Revision Contents
Changeset List

Path

Size

services/

backup/

docker-server/

contents/

server/

src/

BackupServiceImpl.h

39 lines

BackupServiceImpl.cpp

4 lines

Diff 9436

View Options

services/backup/docker-server/contents/server/src/BackupServiceImpl.h