[CommCoreModule] Introduce `PlatformSpecificTools::getDeviceOS()`
ClosedPublic
Actions

Authored by atul on Feb 9 2022, 1:17 PM.

Details

Reviewers

ashoat
• jacek
varun
tomek
• karol
• jim

Commits

rCOMM6441b1c3300b: [CommCoreModule] Introduce `PlatformSpecificTools::getDeviceOS()`

Summary

We need deviceOS for SessionSignature(...) unary gRPC call

Test Plan

Call function and log result. Only tested on iOS thus far, will test android before landing

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Feb 9 2022, 1:17 PM

Herald added subscribers: • benschac, • adrian. · View Herald TranscriptFeb 9 2022, 1:17 PM

Harbormaster completed remote builds in B6695: Diff 9498.Feb 9 2022, 1:23 PM

atul requested review of this revision.Feb 9 2022, 1:23 PM

ashoat accepted this revision.Feb 9 2022, 10:09 PM

ashoat added a reviewer: • jim.

This revision is now accepted and ready to land.Feb 9 2022, 10:09 PM

Could do something to avoid reinstantiating these strings, but I guess they're small-string optimized on the stack and what-have-you and maybe even get inlined

Could do something to avoid reinstantiating these strings, but I guess they're small-string optimized on the stack and what-have-you and maybe even get inlined

My instinct was also that the small string optimization would take care of us. Going to land as-is, but can always optimize later if we come across a better approach

rebase before landing

Harbormaster completed remote builds in B6717: Diff 9530.Feb 10 2022, 7:41 AM

Closed by commit rCOMM6441b1c3300b: [CommCoreModule] Introduce `PlatformSpecificTools::getDeviceOS()` (authored by atul). · Explain WhyFeb 10 2022, 7:47 AM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM6441b1c3300b: [CommCoreModule] Introduce `PlatformSpecificTools::getDeviceOS()`.