Page MenuHomePhabricator

Introduce changes in imports and error messages needed after renaming server to keyserver
AbandonedPublic

Authored by marcin on Feb 25 2022, 5:24 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 25, 3:01 AM
Unknown Object (File)
Fri, Nov 8, 8:16 PM
Unknown Object (File)
Fri, Nov 8, 8:16 PM
Unknown Object (File)
Fri, Nov 8, 8:16 PM
Unknown Object (File)
Fri, Nov 8, 8:16 PM
Unknown Object (File)
Fri, Nov 8, 8:16 PM
Unknown Object (File)
Fri, Nov 8, 8:16 PM
Unknown Object (File)
Fri, Nov 8, 8:16 PM

Details

Reviewers
tomek
ashoat
Summary

Make all necessary changes in files responsible for running application parts that are affected by renaming server directory to keyserver. Changes that are needed in comments, and *.md files will be a part of child revision.

Test Plan

Build android, ios and web version of the application, see that they work. Phabricator CI is also intended to provide testing mechanism.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

tomek requested changes to this revision.Feb 28 2022, 6:58 AM

In the title it is said that and make necessary changes anywhere path 'comm/server/*' was used, but in summary Changes that are needed in comments, and *.md files will be a part of child revision. which contradicts each other.
If in this diff there are important changes it is impossible to review them as Phabricator collapses all the diffs. We need to change this diff to contain just the rename of the folder and a new diff with other changes. I know this will leave the code in an incorrect state, but I can't see any other way to review this.

This revision now requires changes to proceed.Feb 28 2022, 6:58 AM

Now this diff contains only files which code changed after renaming server to keyserver.

marcin retitled this revision from Rename server directory to keyserver and make necessary changes anywhere path 'comm/server/*' was used to Introduce changes in imports and error messages needed after renaming server to keyserver.
marcin edited the summary of this revision. (Show Details)

Change some deletions into modifications

tomek added a reviewer: ashoat.
tomek added inline comments.
.lintstagedrc.js
25 ↗(On Diff #9983)

keyserver is a single word

keyserver/loader.mjs
1–2 ↗(On Diff #9983)

Are you sure flow is can check this file? resolve function doesn't have type declaration and we're exporting it, so I would expect flow to give an error here.

This revision is now accepted and ready to land.Mar 1 2022, 5:46 AM

Overall, this looks good... but I haven't actually ran git grep server, so I'm not sure if you might've accidentally missed something

.lintstagedrc.js
25 ↗(On Diff #9983)

+1

keyserver/loader.mjs
1–2 ↗(On Diff #9983)

Yeah I don't think there's a reason to add the @flow annotation here

Retrigger CI after rebasing

Introduce essential changes in keyserver production scripts