[web] [refactor] move default input styling to input component
AbandonedPublic
Actions

Authored by • benschac on Feb 25 2022, 11:17 AM.

Details

Reviewers

Summary

we should only be using input components and their styling. Moving the global input styling and moving it to the input component.

before:

after:

Test Plan

look at input component. They're still not styled 100%, but they shouldn't change. https://developer.mozilla.org/en-US/docs/Web/CSS/appearance appearance properties are just removing default browser styling.

Repository

rCOMM Comm

Branch

fix-border-radius

Lint

No Lint Coverage

Unit

No Test Coverage

• benschac requested review of this revision.Feb 25 2022, 11:22 AM

atul requested changes to this revision.Mar 2 2022, 8:05 AM

atul added inline comments.

web/style.css
30–32	Moving the global input styling and moving it to the input component. Then why are we keeping styles like `border` and `border-radius`? Don't these styles also affect the `<textarea>` tag? Are you sure we want to be removing these styles for that as well? Or should we break this into two separate selectors (one for `input` and another for `textarea`)?

This revision now requires changes to proceed.Mar 2 2022, 8:05 AM

• benschac added inline comments.

web/style.css
30–32	Yeah, I should break these styles out a bit more. I don't think they really do anything. But you make a good point that this will also effect `textarea` elements.