styles are in Input component and are no longer needed.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- fix-border-radius
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
Okay, historically I was told do one thing in a diff. That one thing is move or delete. Does combining a diff like this make sense @ashoat? If so could we document it somewhere?
Comment Actions
Personally I would keep these diffs separate. They seem logically separate to me. Here are some questions you can ask to determine if two changes should be combined into the same diff:
- "Is it more mental overhead two think of these two changes together, or to think of them separately?"
- "Can I come up with a clear and concise diff title for each of these two changes? Can I come up with a clear and concise diff title for the two changes combined?"
Comment Actions
Eh I disagree but it's fine..
The combined diffs would still be a single move operation.. but instead we have a partial move followed by another diff that completes the move
"Is it more mental overhead two think of these two changes together, or to think of them separately?"
More mental overhead to make the connection between two separate diffs than to see it all in one place.