Page MenuHomePhabricator
Differential D3308

[web] Fix typo in `style.css`
ClosedPublic
Actions

Authored by atul on Feb 28 2022, 3:13 PM.
Tags
None
Referenced Files
F2199572: D3308.diff
Fri, Jul 5, 8:50 PM
F2197093: D3308.id.diff
Fri, Jul 5, 2:15 PM
F2195816: D3308.id9996.diff
Fri, Jul 5, 11:17 AM
Unknown Object (File)
Thu, Jul 4, 12:05 PM
Unknown Object (File)
Thu, Jul 4, 5:11 AM
Unknown Object (File)
Tue, Jul 2, 9:51 AM
Unknown Object (File)
Tue, Jul 2, 6:39 AM
Unknown Object (File)
Sun, Jun 16, 12:12 PM
View All 81 Files
Subscribers
• adrian
ashoat
• karol

Details

Reviewers
• jacek
tomek
varun
• benschac
Commits
rCOMM13216d67276e: [web] Fix typo in `style.css`
Summary

NA

Test Plan

NA

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Feb 28 2022, 3:13 PM
Herald added subscribers: • karol, • adrian, ashoat. · View Herald TranscriptFeb 28 2022, 3:14 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Feb 28 2022, 3:17 PM
Harbormaster failed remote builds in B7075: Diff 9966!
Harbormaster completed remote builds in B7075: Diff 9966.Feb 28 2022, 4:07 PM
atul requested review of this revision.Feb 28 2022, 4:07 PM
• benschac requested changes to this revision.Feb 28 2022, 4:37 PM

Could you add a screen shot? Does this code even do anything? Maybe it should be removed?

This revision now requires changes to proceed.Feb 28 2022, 4:37 PM
atul added a comment.Feb 28 2022, 5:55 PM

Could you add a screen shot? Does this code even do anything? Maybe it should be removed?

There's a <header> with className header in both splash.react.js and app.react.js.. which corresponds to the header:

b8a8.png (130×3 px, 44 KB)

The typo was "covered up" by the div.main-header within the header which has its background set to var(--bg).

The typo was mistakenly introduced in this commit: https://phabricator.ashoat.com/D2928

atul requested review of this revision.Feb 28 2022, 5:55 PM
tomek accepted this revision.Mar 1 2022, 3:28 AM
This revision was not accepted when it landed; it landed in state Needs Review.Mar 1 2022, 7:04 AM
Closed by commit rCOMM13216d67276e: [web] Fix typo in `style.css` (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM13216d67276e: [web] Fix typo in `style.css`.
ashoat added a comment.Mar 1 2022, 8:37 AM

@atul, please do not land diffs that are not in an accepted state. If you do find yourself needing to do that, please add a comment to the diff explaining why you're doing it. Your current pattern is normalizing this behavior on the team and I would like us to avoid normalizing it.

Revision Contents
Changeset List

PathSize
web/
2 lines

Diff 9996

View Options

web/style.css

Loading...