Page MenuHomePhabricator
Differential D3310

[web] Remove extraneous `sidebarExistsOrCanBeCreated` prop in `MessageActionButtons`
ClosedPublic
Actions

Authored by atul on Feb 28 2022, 3:55 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 15, 8:34 PM
Unknown Object (File)
Tue, Apr 8, 6:11 PM
Unknown Object (File)
Tue, Apr 8, 8:54 AM
Unknown Object (File)
Tue, Apr 8, 7:34 AM
Unknown Object (File)
Tue, Apr 8, 6:28 AM
Unknown Object (File)
Wed, Apr 2, 12:51 AM
Unknown Object (File)
Tue, Apr 1, 5:27 AM
Unknown Object (File)
Mon, Mar 31, 12:40 PM
View All Files
Subscribers
• adrian
ashoat
• karol

Details

Reviewers
• jacek
tomek
varun
• benschac
Commits
rCOMM93d079ef9a8c: [web] Remove extraneous `sidebarExistsOrCanBeCreated` prop in…
Summary

Can use useSidebarExistsOrCanBeCreated hook directly instead of "drilling" it in.

Test Plan

Close reading, things seem to continue working as expected

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

Diff 10114

View Options

web/chat/composed-message.react.js

Show First 20 Lines • Show All 148 Lines • ▼ Show 20 Lines render(): React.Node {
const textInputs = []; const textInputs = [];
if (this.state.textInputKey > 0) { if (this.state.textInputKey > 0) {
textInputs.push( textInputs.push(
<TextInput <TextInput
{...props} {...props}
style={[props.style, styles.invisibleTextInput]} style={[props.style, styles.invisibleTextInput]}
onChangeText={this.onOldInputChangeText} onChangeText={this.onOldInputChangeText}
onSelectionChange={this.props.onSelectionChange}
onKeyPress={this.onOldInputKeyPress} onKeyPress={this.onOldInputKeyPress}
onBlur={this.onOldInputBlur} onBlur={this.onOldInputBlur}
onFocus={this.onOldInputFocus} onFocus={this.onOldInputFocus}
key={this.state.textInputKey - 1} key={this.state.textInputKey - 1}
/>, />,
); );
} }
textInputs.push( textInputs.push(
<TextInput <TextInput
{...props} {...props}
onFocus={this.onFocus} onFocus={this.onFocus}
onBlur={this.onBlur} onBlur={this.onBlur}
onChangeText={this.props.onChangeText} onChangeText={this.props.onChangeText}
onSelectionChange={this.props.onSelectionChange}
key={this.state.textInputKey} key={this.state.textInputKey}
ref={this.textInputRef} ref={this.textInputRef}
/>, />,
); );
return <View style={styles.textInputContainer}>{textInputs}</View>; return <View style={styles.textInputContainer}>{textInputs}</View>;
} }
} }
Show All 12 Lines
View Options

web/chat/message-action-buttons.js

Show First 20 Lines • Show All 148 Lines • ▼ Show 20 Lines render(): React.Node {
const textInputs = []; const textInputs = [];
if (this.state.textInputKey > 0) { if (this.state.textInputKey > 0) {
textInputs.push( textInputs.push(
<TextInput <TextInput
{...props} {...props}
style={[props.style, styles.invisibleTextInput]} style={[props.style, styles.invisibleTextInput]}
onChangeText={this.onOldInputChangeText} onChangeText={this.onOldInputChangeText}
onSelectionChange={this.props.onSelectionChange}
onKeyPress={this.onOldInputKeyPress} onKeyPress={this.onOldInputKeyPress}
onBlur={this.onOldInputBlur} onBlur={this.onOldInputBlur}
onFocus={this.onOldInputFocus} onFocus={this.onOldInputFocus}
key={this.state.textInputKey - 1} key={this.state.textInputKey - 1}
/>, />,
); );
} }
textInputs.push( textInputs.push(
<TextInput <TextInput
{...props} {...props}
onFocus={this.onFocus} onFocus={this.onFocus}
onBlur={this.onBlur} onBlur={this.onBlur}
onChangeText={this.props.onChangeText} onChangeText={this.props.onChangeText}
onSelectionChange={this.props.onSelectionChange}
key={this.state.textInputKey} key={this.state.textInputKey}
ref={this.textInputRef} ref={this.textInputRef}
/>, />,
); );
return <View style={styles.textInputContainer}>{textInputs}</View>; return <View style={styles.textInputContainer}>{textInputs}</View>;
} }
} }
Show All 12 Lines