Page MenuHomePhabricator
Differential D3311

[web] Remove extraneous `containerPosition` prop from `MessageActionButtons`
ClosedPublic
Actions

Authored by atul on Feb 28 2022, 6:27 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 17, 7:41 AM
Unknown Object (File)
Tue, Dec 17, 7:41 AM
Unknown Object (File)
Tue, Dec 17, 7:40 AM
Unknown Object (File)
Tue, Dec 17, 7:40 AM
Unknown Object (File)
Tue, Dec 17, 7:40 AM
Unknown Object (File)
Tue, Dec 17, 7:38 AM
Unknown Object (File)
Mon, Dec 2, 8:18 PM
Unknown Object (File)
Mon, Dec 2, 8:18 PM
View All Files
Subscribers
• adrian
ashoat
• karol

Details

Reviewers
• jacek
tomek
varun
• benschac
Commits
rCOMM3f7eaeea385d: [web] Remove extraneous `containerPosition` prop from `MessageActionButtons`
Summary

We can get containerPosition from mouseOverMessagePosition instead of passing it in directly as a prop

Test Plan

NA, flow

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Feb 28 2022, 6:27 PM
Herald added subscribers: • karol, • adrian, ashoat. · View Herald TranscriptFeb 28 2022, 6:27 PM
Harbormaster completed remote builds in B7080: Diff 9971.Feb 28 2022, 6:32 PM
atul requested review of this revision.Feb 28 2022, 6:32 PM
atul updated this revision to Diff 9973.Feb 28 2022, 6:35 PM

rebase

Harbormaster completed remote builds in B7082: Diff 9973.Feb 28 2022, 6:42 PM
tomek accepted this revision.Mar 1 2022, 3:36 AM
This revision is now accepted and ready to land.Mar 1 2022, 3:36 AM
atul mentioned this in D3306: [web] Move `replyButton` from `ComposedMessage` to `MessageActionButtons`.Mar 7 2022, 6:49 AM
atul updated this revision to Diff 10115.Mar 7 2022, 9:44 AM

rebase

Harbormaster completed remote builds in B7186: Diff 10115.Mar 7 2022, 9:52 AM
Closed by commit rCOMM3f7eaeea385d: [web] Remove extraneous `containerPosition` prop from `MessageActionButtons` (authored by atul). · Explain WhyMar 8 2022, 11:35 AM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM3f7eaeea385d: [web] Remove extraneous `containerPosition` prop from `MessageActionButtons`.

Revision Contents
Changeset List

Diff 10180

View Options

web/chat/composed-message.react.js

Loading...
View Options

web/chat/message-action-buttons.js

Loading...
View Options

web/chat/robotext-message.react.js

Loading...