Page MenuHomePhabricator
Differential D3311

[web] Remove extraneous `containerPosition` prop from `MessageActionButtons`
ClosedPublic
Actions

Authored by atul on Feb 28 2022, 6:27 PM.
Tags
None
Referenced Files
F6148888: D3311.diff
Tue, Apr 22, 1:10 PM
Unknown Object (File)
Tue, Apr 15, 8:34 PM
Unknown Object (File)
Tue, Apr 8, 7:10 AM
Unknown Object (File)
Tue, Apr 8, 6:20 AM
Unknown Object (File)
Tue, Apr 1, 6:06 AM
Unknown Object (File)
Mon, Mar 31, 8:52 PM
Unknown Object (File)
Mar 6 2025, 8:53 PM
Unknown Object (File)
Feb 20 2025, 9:17 PM
View All Files
Subscribers
• adrian
ashoat
• karol

Details

Reviewers
• jacek
tomek
varun
• benschac
Commits
rCOMM3f7eaeea385d: [web] Remove extraneous `containerPosition` prop from `MessageActionButtons`
Summary

We can get containerPosition from mouseOverMessagePosition instead of passing it in directly as a prop

Test Plan

NA, flow

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Feb 28 2022, 6:27 PM
Herald added subscribers: • karol, • adrian, ashoat. · View Herald TranscriptFeb 28 2022, 6:27 PM
Harbormaster completed remote builds in B7080: Diff 9971.Feb 28 2022, 6:32 PM
atul requested review of this revision.Feb 28 2022, 6:32 PM
atul updated this revision to Diff 9973.Feb 28 2022, 6:35 PM

rebase

Harbormaster completed remote builds in B7082: Diff 9973.Feb 28 2022, 6:42 PM
tomek accepted this revision.Mar 1 2022, 3:36 AM
This revision is now accepted and ready to land.Mar 1 2022, 3:36 AM
atul mentioned this in D3306: [web] Move `replyButton` from `ComposedMessage` to `MessageActionButtons`.Mar 7 2022, 6:49 AM
atul updated this revision to Diff 10115.Mar 7 2022, 9:44 AM

rebase

Harbormaster completed remote builds in B7186: Diff 10115.Mar 7 2022, 9:52 AM
Closed by commit rCOMM3f7eaeea385d: [web] Remove extraneous `containerPosition` prop from `MessageActionButtons` (authored by atul). · Explain WhyMar 8 2022, 11:35 AM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM3f7eaeea385d: [web] Remove extraneous `containerPosition` prop from `MessageActionButtons`.

Revision Contents
Changeset List

Diff 10180

View Options

web/chat/composed-message.react.js

Show First 20 Lines • Show All 148 Lines • ▼ Show 20 Lines render(): React.Node {
const textInputs = []; const textInputs = [];
if (this.state.textInputKey > 0) { if (this.state.textInputKey > 0) {
textInputs.push( textInputs.push(
<TextInput <TextInput
{...props} {...props}
style={[props.style, styles.invisibleTextInput]} style={[props.style, styles.invisibleTextInput]}
onChangeText={this.onOldInputChangeText} onChangeText={this.onOldInputChangeText}
onSelectionChange={this.props.onSelectionChange}
onKeyPress={this.onOldInputKeyPress} onKeyPress={this.onOldInputKeyPress}
onBlur={this.onOldInputBlur} onBlur={this.onOldInputBlur}
onFocus={this.onOldInputFocus} onFocus={this.onOldInputFocus}
key={this.state.textInputKey - 1} key={this.state.textInputKey - 1}
/>, />,
); );
} }
textInputs.push( textInputs.push(
<TextInput <TextInput
{...props} {...props}
onFocus={this.onFocus} onFocus={this.onFocus}
onBlur={this.onBlur} onBlur={this.onBlur}
onChangeText={this.props.onChangeText} onChangeText={this.props.onChangeText}
onSelectionChange={this.props.onSelectionChange}
key={this.state.textInputKey} key={this.state.textInputKey}
ref={this.textInputRef} ref={this.textInputRef}
/>, />,
); );
return <View style={styles.textInputContainer}>{textInputs}</View>; return <View style={styles.textInputContainer}>{textInputs}</View>;
} }
} }
Show All 12 Lines
View Options

web/chat/message-action-buttons.js

Show First 20 Lines • Show All 148 Lines • ▼ Show 20 Lines render(): React.Node {
const textInputs = []; const textInputs = [];
if (this.state.textInputKey > 0) { if (this.state.textInputKey > 0) {
textInputs.push( textInputs.push(
<TextInput <TextInput
{...props} {...props}
style={[props.style, styles.invisibleTextInput]} style={[props.style, styles.invisibleTextInput]}
onChangeText={this.onOldInputChangeText} onChangeText={this.onOldInputChangeText}
onSelectionChange={this.props.onSelectionChange}
onKeyPress={this.onOldInputKeyPress} onKeyPress={this.onOldInputKeyPress}
onBlur={this.onOldInputBlur} onBlur={this.onOldInputBlur}
onFocus={this.onOldInputFocus} onFocus={this.onOldInputFocus}
key={this.state.textInputKey - 1} key={this.state.textInputKey - 1}
/>, />,
); );
} }
textInputs.push( textInputs.push(
<TextInput <TextInput
{...props} {...props}
onFocus={this.onFocus} onFocus={this.onFocus}
onBlur={this.onBlur} onBlur={this.onBlur}
onChangeText={this.props.onChangeText} onChangeText={this.props.onChangeText}
onSelectionChange={this.props.onSelectionChange}
key={this.state.textInputKey} key={this.state.textInputKey}
ref={this.textInputRef} ref={this.textInputRef}
/>, />,
); );
return <View style={styles.textInputContainer}>{textInputs}</View>; return <View style={styles.textInputContainer}>{textInputs}</View>;
} }
} }
Show All 12 Lines
View Options

web/chat/robotext-message.react.js

Show First 20 Lines • Show All 148 Lines • ▼ Show 20 Lines render(): React.Node {
const textInputs = []; const textInputs = [];
if (this.state.textInputKey > 0) { if (this.state.textInputKey > 0) {
textInputs.push( textInputs.push(
<TextInput <TextInput
{...props} {...props}
style={[props.style, styles.invisibleTextInput]} style={[props.style, styles.invisibleTextInput]}
onChangeText={this.onOldInputChangeText} onChangeText={this.onOldInputChangeText}
onSelectionChange={this.props.onSelectionChange}
onKeyPress={this.onOldInputKeyPress} onKeyPress={this.onOldInputKeyPress}
onBlur={this.onOldInputBlur} onBlur={this.onOldInputBlur}
onFocus={this.onOldInputFocus} onFocus={this.onOldInputFocus}
key={this.state.textInputKey - 1} key={this.state.textInputKey - 1}
/>, />,
); );
} }
textInputs.push( textInputs.push(
<TextInput <TextInput
{...props} {...props}
onFocus={this.onFocus} onFocus={this.onFocus}
onBlur={this.onBlur} onBlur={this.onBlur}
onChangeText={this.props.onChangeText} onChangeText={this.props.onChangeText}
onSelectionChange={this.props.onSelectionChange}
key={this.state.textInputKey} key={this.state.textInputKey}
ref={this.textInputRef} ref={this.textInputRef}
/>, />,
); );
return <View style={styles.textInputContainer}>{textInputs}</View>; return <View style={styles.textInputContainer}>{textInputs}</View>;
} }
} }
Show All 12 Lines