[web] [fix] regression: chat tabs disabled lost its bottom border when changing global border color.
ClosedPublic
Actions

Authored by • benschac on Mar 1 2022, 2:57 PM.

Details

Reviewers

atul
tomek

Commits

rCOMMe43acc88c5c1: [web] [fix] regression: chat tabs disabled lost its bottom border when changing…

Summary

Image 2022-03-01 at 5.54.40 PM.jpg (1×1 px, 99 KB)

disabled state should match figma

Currently master looks like this:

Image 2022-03-01 at 6.00.21 PM.jpg (698×1 px, 68 KB)

Regression was added here: https://github.com/CommE2E/comm/commit/b64048cb2096a5c96c52212a16f0f125f581b31e

Test Plan

check figma: https://www.figma.com/file/a1nkbWgbgjRlrOY9LVurTz/?node-id=1170%3A77104 that the design looks correct. Toggle background and focused

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• benschac created this revision.Mar 1 2022, 2:57 PM

Herald added subscribers: • karol, • adrian, tomek, ashoat. · View Herald TranscriptMar 1 2022, 2:57 PM

• benschac edited the summary of this revision. (Show Details)Mar 1 2022, 2:58 PM

• benschac edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B7099: Diff 10006.Mar 1 2022, 3:02 PM

• benschac requested review of this revision.Mar 1 2022, 3:02 PM

• benschac added a reviewer: tomek.Mar 1 2022, 4:09 PM

tomek accepted this revision.Mar 2 2022, 3:20 AM

This revision is now accepted and ready to land.Mar 2 2022, 3:20 AM

• benschac awarded a token.Mar 2 2022, 4:39 AM

Closed by commit rCOMMe43acc88c5c1: [web] [fix] regression: chat tabs disabled lost its bottom border when changing… (authored by • benschac). · Explain WhyMar 2 2022, 4:41 AM

This revision was automatically updated to reflect the committed changes.

• benschac added a commit: rCOMMe43acc88c5c1: [web] [fix] regression: chat tabs disabled lost its bottom border when changing….

Revision Contents
Changeset List

Path

Size

web/

chat/

chat-tabs.css

2 lines

Diff 10006

View Options

[web] [fix] regression: chat tabs disabled lost its bottom border when changing global border color.ClosedPublicActions