Page MenuHomePhabricator
Differential D3349

[server] Always filter message queries by message creation time
ClosedPublic
Actions

Authored by ashoat on Mar 6 2022, 3:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 6, 11:36 AM
Unknown Object (File)
Sat, Nov 2, 8:32 AM
Unknown Object (File)
Sun, Oct 27, 12:58 AM
Unknown Object (File)
Sun, Oct 27, 12:58 AM
Unknown Object (File)
Sat, Oct 26, 8:12 PM
Unknown Object (File)
Sat, Oct 26, 8:11 PM
Unknown Object (File)
Sat, Oct 26, 8:11 PM
Unknown Object (File)
Oct 7 2024, 6:38 AM
View All Files
Subscribers
• adrian
• benschac
• karol

Details

Reviewers
tomek
atul
Commits
rCOMM97cea65d1b74: [server] Always filter message queries by message creation time
Summary

This solves ENG-812: Improve perf of website load. By limiting the amount of messages that MySQL has to look at in order to resolve fetchMessageInfos, we speed up website load significantly.

On my local environment using the prod database, the query resolves in 0.5s instead of 20s.

Depends On D3348

Test Plan

I downloaded the prod database to my local machine and tested how long the query to load the website took. This change reduced it from 20s to 0.5s

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.Mar 6 2022, 3:44 PM
Herald added subscribers: • karol, • adrian. · View Herald TranscriptMar 6 2022, 3:44 PM
ashoat mentioned this in D3350: [lib] Don't assume freshMessageStore always has messages for a thread.Mar 6 2022, 3:45 PM
ashoat added a child revision: D3350: [lib] Don't assume freshMessageStore always has messages for a thread.Mar 6 2022, 3:48 PM
ashoat edited the summary of this revision. (Show Details)
ashoat added a parent revision: D3348: [server] Move fetchMessageInfosSince's currentAsOf param to MessageSelectionCriteria.
Harbormaster completed remote builds in B7168: Diff 10094.Mar 6 2022, 3:55 PM
ashoat requested review of this revision.Mar 6 2022, 3:55 PM
ashoat mentioned this in D3354: [server] Gate global time filter for message queries on codeVersion.Mar 6 2022, 10:16 PM
ashoat added a comment.Mar 6 2022, 10:16 PM

I realized I should probably gate this behind a hasMinCodeVersion given native needs D3350, D3352, and D3353 to work properly with this change. Just put up D3354 to gate the changes

• benschac added a subscriber: • benschac.Mar 7 2022, 6:52 AM
• benschac added inline comments.
lib/types/message-types.js
471 ↗(On Diff #10094)

q: Could you add a comment here with the normalized amount of time here? I'm assuming it's two weeks at a glance but wasn't 100%.

Also, might just be me but it feels odd that there's a time value in message-types

ashoat updated this revision to Diff 10133.Mar 7 2022, 10:38 PM

Added "2 weeks" comment

Harbormaster completed remote builds in B7204: Diff 10133.Mar 7 2022, 10:43 PM
tomek accepted this revision.Mar 8 2022, 6:46 AM

On my local environment using the prod database, the query resolves in 0.5s instead of 20s.

It's great to hear that!

This revision is now accepted and ready to land.Mar 8 2022, 6:46 AM
ashoat updated this revision to Diff 10145.Mar 8 2022, 7:45 AM

Rebase

Harbormaster completed remote builds in B7215: Diff 10145.Mar 8 2022, 7:57 AM
Closed by commit rCOMM97cea65d1b74: [server] Always filter message queries by message creation time (authored by ashoat). · Explain WhyMar 8 2022, 8:32 AM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM97cea65d1b74: [server] Always filter message queries by message creation time.
ashoat mentioned this in rCOMM00e559c14bef: [server] Gate global time filter for message queries on codeVersion.

Revision Contents
Changeset List

PathSize
lib/
types/
1 line
server/
src/
fetchers/
19 lines

Diff 10145

View Options

lib/types/message-types.js

Loading...
View Options

server/src/fetchers/message-fetchers.js

Loading...