Page MenuHomePhabricator
Differential D3351

[web] Make ChatMessageList able to fetch messages if none are present
ClosedPublic
Actions

Authored by ashoat on Mar 6 2022, 3:46 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Feb 16, 11:23 PM
Unknown Object (File)
Jan 28 2025, 7:08 AM
Unknown Object (File)
Jan 15 2025, 8:01 PM
Unknown Object (File)
Jan 15 2025, 2:20 AM
Unknown Object (File)
Jan 14 2025, 3:52 AM
Unknown Object (File)
Jan 14 2025, 3:52 AM
Unknown Object (File)
Jan 14 2025, 3:52 AM
Unknown Object (File)
Jan 14 2025, 3:52 AM
View All Files
Subscribers
• adrian
• benschac
• karol

Details

Reviewers
tomek
atul
Commits
rCOMM67a0a9646da7: [web] Make ChatMessageList able to fetch messages if none are present
Summary

With the changes in the earlier diff, we may end up with zero messages for a given thread. This diff makes it possible for us to fetch messages in that case.

Depends On D3350

Test Plan

I decreased defaultMaxMessageAge such that no messages got loaded at all, and made sure that when I opened a thread without messages, the messages were fetche
d

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.Mar 6 2022, 3:46 PM
Herald added subscribers: • karol, • adrian. · View Herald TranscriptMar 6 2022, 3:46 PM
ashoat edited the summary of this revision. (Show Details)Mar 6 2022, 3:47 PM
ashoat added a parent revision: D3350: [lib] Don't assume freshMessageStore always has messages for a thread.
ashoat updated this revision to Diff 10097.Mar 6 2022, 3:58 PM

Use correct action type

Harbormaster completed remote builds in B7170: Diff 10096.Mar 6 2022, 4:03 PM
Harbormaster completed remote builds in B7171: Diff 10097.Mar 6 2022, 4:07 PM
ashoat requested review of this revision.Mar 6 2022, 4:07 PM
ashoat added a child revision: D3352: [native] Make MessageList able to fetch messages if none are present.Mar 6 2022, 4:18 PM
tomek accepted this revision.Mar 8 2022, 6:50 AM
This revision is now accepted and ready to land.Mar 8 2022, 6:50 AM
Herald added a subscriber: • benschac. · View Herald TranscriptMar 8 2022, 6:50 AM
ashoat updated this revision to Diff 10147.Mar 8 2022, 7:46 AM

Rebase

Harbormaster completed remote builds in B7217: Diff 10147.Mar 8 2022, 8:06 AM
Closed by commit rCOMM67a0a9646da7: [web] Make ChatMessageList able to fetch messages if none are present (authored by ashoat). · Explain WhyMar 8 2022, 8:32 AM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM67a0a9646da7: [web] Make ChatMessageList able to fetch messages if none are present.
ashoat mentioned this in D3411: [server] Don't unset TRUNCATED if threadCursor is null.Mar 11 2022, 11:39 AM
ashoat mentioned this in rCOMM362a843ed259: [server] Don't unset TRUNCATED if threadCursor is null.Mar 14 2022, 12:47 PM

Revision Contents
Changeset List

PathSize
web/
chat/
30 lines

Diff 10097

View Options

web/chat/chat-message-list.react.js

Loading...