Paths

Table of Contentst

Differential D3360

[web] Fix unread sidebar title styling in `SidebarItem`
ClosedPublic
Actions

Authored by atul on Mar 7 2022, 4:55 PM.

Tags

None

Referenced Files

	F3301703: D3360.diff
	Mon, Nov 18, 3:30 AM

	Unknown Object (File)
	Mon, Nov 11, 1:35 AM

	Unknown Object (File)
	Fri, Nov 8, 10:39 PM

	Unknown Object (File)
	Fri, Nov 8, 10:39 PM

	Unknown Object (File)
	Sat, Nov 2, 8:55 AM

	Unknown Object (File)
	Sat, Nov 2, 8:55 AM

	Unknown Object (File)
	Sat, Nov 2, 8:55 AM

	Unknown Object (File)
	Sat, Nov 2, 8:53 AM

Subscribers

Details

Reviewers

• jacek
tomek
varun
• benschac

Commits

rCOMMed3e53aa1251: [web] Fix unread sidebar title styling in `SidebarItem`

Summary

Looks as expected:

Test Plan

NA

Diff Detail

Repository

Branch

feb24 (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Mar 7 2022, 4:55 PM

Herald added subscribers: • karol, • adrian, ashoat. · View Herald TranscriptMar 7 2022, 4:55 PM

Harbormaster completed remote builds in B7194: Diff 10123.Mar 7 2022, 5:01 PM

atul requested review of this revision.Mar 7 2022, 5:01 PM

tomek accepted this revision.Mar 8 2022, 8:10 AM

tomek added inline comments.

web/chat/chat-thread-list.css
135–137	I'd probably just use `div.unread`, so that it's more maintainable. Currently, we're assigning `css.unread` to `unreadCls` but this has any effect only when `css.sidebarTitle` is also present.

This revision is now accepted and ready to land.Mar 8 2022, 8:10 AM

atul added inline comments.Mar 8 2022, 9:50 AM

web/chat/chat-thread-list.css
135–137	Yeah there's some issues with specificity that made this weirdly challenging the way things are set up. I'm going to land as-is to unblock deploy. But, cleaning this up is the first thing I'm going to do after landing these diffs.

Closed by commit rCOMMed3e53aa1251: [web] Fix unread sidebar title styling in `SidebarItem` (authored by atul). · Explain WhyMar 8 2022, 9:51 AM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMMed3e53aa1251: [web] Fix unread sidebar title styling in `SidebarItem`.

Whenever you defer doing something that a reviewer has asked you to do, you should always create a Linear task to track!

https://linear.app/comm/issue/ENG-850/clean-up-unread-style-specificity-in-sidebaritem

Revision Contents
Changeset List

Path

Size

web/

chat/

chat-thread-list.css

3 lines

sidebar-item.react.js

2 lines

Diff 10123

web/chat/chat-thread-list.css

Loading...

web/chat/sidebar-item.react.js

Loading...