Page MenuHomePhabricator
Differential D3364

[web] Set `cursor: pointer` for `sendButton`
ClosedPublic
Actions

Authored by atul on Mar 7 2022, 9:27 PM.
Tags
None
Referenced Files
F3376828: D3364.diff
Wed, Nov 27, 2:27 AM
Unknown Object (File)
Fri, Nov 15, 6:36 PM
Unknown Object (File)
Wed, Nov 13, 12:38 PM
Unknown Object (File)
Wed, Nov 13, 12:38 PM
Unknown Object (File)
Sat, Nov 9, 9:29 PM
Unknown Object (File)
Sat, Nov 9, 5:47 PM
Unknown Object (File)
Sat, Nov 9, 3:49 PM
Unknown Object (File)
Sat, Nov 9, 2:31 PM
View All Files
Subscribers
• adrian
ashoat
• karol

Details

Reviewers
• jacek
tomek
• benschac
varun
Commits
rCOMM1c7419d81732: [web] Set `cursor: pointer` for `sendButton`
Summary

NA, looks as expected

Test Plan

NA, looks as expected

Diff Detail

Repository
rCOMM Comm
Branch
feb24 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Mar 7 2022, 9:27 PM
Herald added subscribers: • karol, • adrian, ashoat. · View Herald TranscriptMar 7 2022, 9:27 PM
Harbormaster completed remote builds in B7200: Diff 10129.Mar 7 2022, 9:31 PM
atul requested review of this revision.Mar 7 2022, 9:31 PM
• benschac accepted this revision.Mar 8 2022, 8:04 AM
This revision is now accepted and ready to land.Mar 8 2022, 8:04 AM
tomek added a comment.Mar 8 2022, 8:06 AM

My guess is that we should globally set cursor: pointer on any a and button in the whole codebase

ashoat added a comment.Mar 8 2022, 9:28 AM

I think @palys-swm's suggestion makes sense

atul added a comment.Mar 8 2022, 10:10 AM

My guess is that we should globally set cursor: pointer on any a and button in the whole codebase

I'll put up a diff to do that after landing what's up.

Closed by commit rCOMM1c7419d81732: [web] Set `cursor: pointer` for `sendButton` (authored by atul). · Explain WhyMar 8 2022, 10:57 AM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM1c7419d81732: [web] Set `cursor: pointer` for `sendButton`.
atul mentioned this in D3371: [web] Make all `<a>` and `<button>` `cursor:pointer`.Mar 8 2022, 2:13 PM
atul added a comment.Mar 8 2022, 2:13 PM
In D3364#90810, @palys-swm wrote:

My guess is that we should globally set cursor: pointer on any a and button in the whole codebase

Addressed here: https://phabricator.ashoat.com/D3371

atul mentioned this in rCOMMc2e121f34882: [web] Make all `<a>` and `<button>` `cursor:pointer`.Mar 9 2022, 8:22 AM

Revision Contents
Changeset List

PathSize
web/
chat/
1 line

Diff 10129

View Options

web/chat/chat-input-bar.css

Loading...