[landing] Re-introduce hover styling for `Footer` links
ClosedPublic
Actions

Authored by atul on Mar 7 2022, 9:51 PM.

Details

Reviewers

Commits

Summary

Bring back the hover styling from before. Here's how it looks:

Test Plan

NA, looks as expected

Repository

rCOMM Comm

Branch

landmarch8 (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

atul edited the summary of this revision. (Show Details)Mar 7 2022, 9:53 PM

atul added inline comments.

landing/footer.css
57 ↗	(On Diff #10131)	We don't have all the nice themes figured out like we do on web. But, to be consistent I'm going with `var(--color-disabled)` = `--shades-black-60: #808080` and will make sure to use the same value for hover states throughout

atul requested review of this revision.Mar 7 2022, 9:56 PM

For some reason the uploaded video doesn't seem to load

Weird, here it is attached again:

The upload still doesn't load for me. I had this issue once and the only solution was to record again.

The code looks ok, but would like to see a video before accepting.

landing/footer.css
57–65 ↗	(On Diff #10131)	Not sure about good practices, but we can consider extracting animation styles to one block

This revision now requires changes to proceed.Mar 8 2022, 8:33 AM

The upload still doesn't load for me. I had this issue once and the only solution was to record again.

Ah darn, sorry about that. Attached YouTube and direct link to file as a backup

Thanks! It looks really nice. My personal preference would be to have shorter transition so it feels less laggy. Adding @ashoat to have a look.

My personal preference would be to have shorter transition so it feels less laggy.

Makes sense, I agree that the effect might be a bit too dramatic. 300ms is what we had in the past so I stuck with it, but happy to re-assess.

I'm okay with whatever, but tend to agree that 300ms is a bit long. Maybe 150ms?

This revision is now accepted and ready to land.Mar 8 2022, 10:38 AM

Maybe 150ms?

Sounds good, I'll update before landing

landing/footer.css
57 ↗	(On Diff #10131)	We could make shared util for all colors. Creating an issue here: https://linear.app/comm/issue/ENG-846/create-a-shared-color-and-theming-utility
68 ↗	(On Diff #10131)	Could be a solid opportunity for using `:is` : https://developer.mozilla.org/en-US/docs/Web/CSS/:is