Page MenuHomePhabricator
Differential D3395

[services] Adjust tabs to be two spaces in build_base_image.sh
ClosedPublic
Actions

Authored by ashoat on Mar 10 2022, 8:24 AM.
Tags
None
Referenced Files
F1772710: D3395.diff
Wed, May 15, 8:18 PM
Unknown Object (File)
Sat, Apr 27, 9:59 PM
Unknown Object (File)
Thu, Apr 25, 3:37 AM
Unknown Object (File)
Tue, Apr 23, 1:00 PM
Unknown Object (File)
Tue, Apr 23, 1:00 PM
Unknown Object (File)
Tue, Apr 23, 1:00 PM
Unknown Object (File)
Tue, Apr 23, 12:46 PM
Unknown Object (File)
Mar 27 2024, 6:00 PM
View All 86 Files
Subscribers
• adrian
atul
• benschac
• karol
tomek

Details

Reviewers
• jim
Commits
rCOMM4949e158866b: [services] Adjust tabs to be two spaces in build_base_image.sh
Summary

Minor nit, I left the comment after my accept in D3234 so it was probably missed.

Test Plan

N/A

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat created this revision.Mar 10 2022, 8:24 AM
Herald added subscribers: • benschac, • karol, atul and 2 others. · View Herald TranscriptMar 10 2022, 8:24 AM
Harbormaster completed remote builds in B7280: Diff 10264.Mar 10 2022, 8:29 AM
ashoat requested review of this revision.Mar 10 2022, 8:29 AM
• jim accepted this revision.Mar 10 2022, 11:38 AM

Oops, just updated my .editorconfig

This revision is now accepted and ready to land.Mar 10 2022, 11:38 AM
ashoat added a comment.Mar 10 2022, 12:18 PM

Wonder if we should check in an .editorconfig into the repo

Closed by commit rCOMM4949e158866b: [services] Adjust tabs to be two spaces in build_base_image.sh (authored by ashoat). · Explain WhyMar 10 2022, 12:22 PM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM4949e158866b: [services] Adjust tabs to be two spaces in build_base_image.sh.
• jim added a comment.Mar 10 2022, 12:28 PM
In D3395#91819, @ashoat wrote:

Wonder if we should check in an .editorconfig into the repo

Yes, do recommend

ashoat added a comment.Mar 10 2022, 12:32 PM

Made a task https://linear.app/comm/issue/ENG-860/introduce-editorconfig

Revision Contents
Changeset List

PathSize
services/
scripts/
4 lines

Diff 10276

View Options

services/scripts/build_base_image.sh

Loading...