[services] Adjust tabs to be two spaces in build_base_image.sh
ClosedPublic
Actions

Authored by ashoat on Mar 10 2022, 8:24 AM.

Details

Reviewers

• jim

Commits

rCOMM4949e158866b: [services] Adjust tabs to be two spaces in build_base_image.sh

Summary

Minor nit, I left the comment after my accept in D3234 so it was probably missed.

Test Plan

N/A

Diff Detail

Repository

rCOMM Comm

Branch

ashoat/two-space-tabs

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Mar 10 2022, 8:24 AM

Herald added subscribers: • benschac, • karol, atul and 2 others. · View Herald TranscriptMar 10 2022, 8:24 AM

Harbormaster completed remote builds in B7280: Diff 10264.Mar 10 2022, 8:29 AM

ashoat requested review of this revision.Mar 10 2022, 8:29 AM

Oops, just updated my .editorconfig

This revision is now accepted and ready to land.Mar 10 2022, 11:38 AM

Wonder if we should check in an .editorconfig into the repo

Closed by commit rCOMM4949e158866b: [services] Adjust tabs to be two spaces in build_base_image.sh (authored by ashoat). · Explain WhyMar 10 2022, 12:22 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM4949e158866b: [services] Adjust tabs to be two spaces in build_base_image.sh.

In D3395#91819, @ashoat wrote:

Wonder if we should check in an .editorconfig into the repo

Yes, do recommend

Made a task https://linear.app/comm/issue/ENG-860/introduce-editorconfig

Revision Contents
Changeset List

Path

Size

services/

scripts/

build_base_image.sh

4 lines

Diff 10264

View Options

services/scripts/build_base_image.sh

[services] Adjust tabs to be two spaces in build_base_image.shClosedPublicActions