[web] [chore] add all remaining icons that haven't been imported
ClosedPublic
Actions

Authored by • benschac on Mar 10 2022, 10:24 AM.

Details

Reviewers

atul
tomek
• jacek

Commits

rCOMM2e0df3b75821: [web] [chore] add all remaining icons that haven't been imported

Summary

Add all remaining icons. Icons should all load correct size / color as they did before.

Image 2022-03-10 at 1.30.31 PM.jpg (2×4 px, 669 KB)

Test Plan

double check with figma and before/after that everything looks the same

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• benschac created this revision.Mar 10 2022, 10:24 AM

Herald added subscribers: • karol, • adrian, tomek, ashoat. · View Herald TranscriptMar 10 2022, 10:24 AM

Harbormaster completed remote builds in B7284: Diff 10272.Mar 10 2022, 10:29 AM

• benschac requested review of this revision.Mar 10 2022, 10:29 AM

• benschac edited the summary of this revision. (Show Details)Mar 10 2022, 10:30 AM

• benschac added reviewers: tomek, • jacek.Mar 14 2022, 9:45 AM

Cautiously accepting since it's hard to review

Were you able to convert the paths/strokes to objects/outlines?

This revision is now accepted and ready to land.Mar 14 2022, 4:53 PM

In D3397#92689, @atul wrote:

Cautiously accepting since it's hard to review

Were you able to convert the paths/strokes to objects/outlines?

I didn't, I'm not sure how to. Could you show me how to tomorrow?

talked about this IRL with @atul . Going to land.

Closed by commit rCOMM2e0df3b75821: [web] [chore] add all remaining icons that haven't been imported (authored by • benschac). · Explain WhyMar 16 2022, 10:25 AM

This revision was automatically updated to reflect the committed changes.

• benschac added a commit: rCOMM2e0df3b75821: [web] [chore] add all remaining icons that haven't been imported.

atul mentioned this in D3363: [web] Simplify `AppSwitcher` component and style tabs when active/on hover.Mar 16 2022, 1:43 PM

Revision Contents
Changeset List

Path

Size

web/

icons/

AppIcons.json

12668 lines

selection.json

1192 lines

Diff 10431

View Options

web/icons/AppIcons.json