Page MenuHomePhabricator

[web] [refactor] remove unneeded div in chat-thread-list component
ClosedPublic

Authored by benschac on Mar 10 2022, 1:55 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 24, 10:38 AM
Unknown Object (File)
Sun, Mar 9, 5:56 PM
Unknown Object (File)
Feb 1 2025, 11:24 PM
Unknown Object (File)
Jan 30 2025, 1:24 PM
Unknown Object (File)
Jan 30 2025, 10:38 AM
Unknown Object (File)
Jan 30 2025, 10:38 AM
Unknown Object (File)
Jan 30 2025, 8:48 AM
Unknown Object (File)
Jan 29 2025, 8:40 AM

Details

Summary

remove an extra div we don't need. I hard-coded a color but will remove it in future diffs, along with other unneeded styles. I just didn't want to break existing functionality.

before:

Image 2022-03-10 at 4.45.37 PM.jpg (1×1 px, 120 KB)

after:
Image 2022-03-10 at 4.45.12 PM.jpg (1×1 px, 225 KB)

Test Plan

do a side-by-side with production. Make sure the unread pop up doesn't break.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

benschac added reviewers: jacek, tomek.
benschac edited the summary of this revision. (Show Details)

I hard-coded a color but will remove it in future diffs, along with other unneeded styles. I just didn't want to break existing functionality.

If removing the div requires adding these colors, then adding them was ok, but I think we should still use variables instead of hardcoded values.

This revision is now accepted and ready to land.Mar 11 2022, 5:44 AM
In D3405#92013, @palys-swm wrote:

I hard-coded a color but will remove it in future diffs, along with other unneeded styles. I just didn't want to break existing functionality.

If removing the div requires adding these colors, then adding them was ok, but I think we should still use variables instead of hardcoded values.

Agreed. I'm going to use variables in the future. Just wanted to get rid of this div.