use getAppURLFactsFromRequestURL to choose which app URL facts to use.
depends on D3406
Details
Details
flow
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- varun/eng-660 (branched from master)
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
Looks like Phabricator doesn't recognize "Depends on: Dsomething", it needs you to remove the colon and say "Depends on Dsomething"
| server/src/responders/handlers.js | ||
|---|---|---|
| 40–57 | ||
| server/src/responders/handlers.js | ||
|---|---|---|
| 40–57 | I don't think this works since the the first invocation of getAppURLFactsFromRequestURL is in the try block and the second invocation is in the catch block. I'm going to land this as is but can refactor in a separate diff if you feel strongly about it. | |