Page MenuHomePhabricator
Differential D3413

choose which app url facts to use based on request url
ClosedPublic
Actions

Authored by varun on Mar 11 2022, 12:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jun 23, 11:39 AM
Unknown Object (File)
Sun, Jun 23, 10:30 AM
Unknown Object (File)
Sat, Jun 22, 3:29 PM
Unknown Object (File)
Fri, Jun 21, 11:59 PM
Unknown Object (File)
Fri, Jun 21, 11:59 PM
Unknown Object (File)
Fri, Jun 21, 11:57 PM
Unknown Object (File)
Fri, Jun 21, 11:40 PM
Unknown Object (File)
Thu, Jun 20, 5:17 PM
View All 90 Files
Subscribers
• adrian
ashoat
• benschac
• karol

Details

Reviewers
tomek
atul
ashoat
Commits
rCOMM1e857b8e6fb5: choose which app url facts to use based on request url
Summary

use getAppURLFactsFromRequestURL to choose which app URL facts to use.

depends on D3406

Test Plan

flow

Diff Detail

Repository
rCOMM Comm
Branch
varun/eng-660 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun created this revision.Mar 11 2022, 12:45 PM
Herald added subscribers: • benschac, • karol, • adrian, ashoat. · View Herald TranscriptMar 11 2022, 12:45 PM
Harbormaster completed remote builds in B7316: Diff 10316.Mar 11 2022, 12:50 PM
varun requested review of this revision.Mar 11 2022, 12:50 PM
ashoat edited the summary of this revision. (Show Details)Mar 12 2022, 11:06 AM
ashoat added a parent revision: D3406: [server] initial commit to support new app URL.

Looks like Phabricator doesn't recognize "Depends on: Dsomething", it needs you to remove the colon and say "Depends on Dsomething"

varun added a child revision: D3414: use landing base route path to construct endpoints.Mar 15 2022, 11:21 AM
tomek accepted this revision.Mar 16 2022, 6:17 AM
tomek added a reviewer: ashoat.
tomek added inline comments.
server/src/responders/handlers.js
40–57
ashoat accepted this revision.Mar 16 2022, 9:11 PM
This revision is now accepted and ready to land.Mar 16 2022, 9:11 PM
varun added inline comments.Mar 17 2022, 12:01 PM
server/src/responders/handlers.js
40–57

I don't think this works since the the first invocation of getAppURLFactsFromRequestURL is in the try block and the second invocation is in the catch block. I'm going to land this as is but can refactor in a separate diff if you feel strongly about it.

Closed by commit rCOMM1e857b8e6fb5: choose which app url facts to use based on request url (authored by varun). · Explain WhyMar 17 2022, 12:07 PM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMM1e857b8e6fb5: choose which app url facts to use based on request url.

Revision Contents
Changeset List

PathSize
server/
src/
responders/
56 lines
10 lines
session/
56 lines
utils/
5 lines

Diff 10316

View Options

server/src/responders/handlers.js

Loading...
View Options

server/src/responders/website-responders.js

Loading...
View Options

server/src/session/cookies.js

Loading...
View Options

server/src/utils/security-utils.js

Loading...