Page MenuHomePhabricator
Differential D3414

use landing base route path to construct endpoints
ClosedPublic
Actions

Authored by varun on Mar 11 2022, 2:58 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jun 25, 9:26 AM
Unknown Object (File)
Mon, Jun 24, 4:04 PM
Unknown Object (File)
Sun, Jun 23, 2:26 PM
Unknown Object (File)
Sun, Jun 23, 10:18 AM
Unknown Object (File)
Fri, Jun 21, 11:58 PM
Unknown Object (File)
Fri, Jun 21, 11:58 PM
Unknown Object (File)
Fri, Jun 21, 11:57 PM
Unknown Object (File)
Fri, Jun 21, 11:40 PM
View All 91 Files
Subscribers
• adrian
ashoat
• benschac
• karol

Details

Reviewers
atul
tomek
ashoat
Commits
rCOMM02dc417d09f4: use landing base route path to construct endpoints
Summary

we should avoid hardcoding paths like /commlanding/. instead we should get the paths from the landing_url.json file.

depends on D3413

Test Plan

flow

Diff Detail

Repository
rCOMM Comm
Branch
varun/eng-660 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun created this revision.Mar 11 2022, 2:58 PM
Herald added subscribers: • benschac, • karol, • adrian, ashoat. · View Herald TranscriptMar 11 2022, 2:58 PM
Harbormaster completed remote builds in B7317: Diff 10318.Mar 11 2022, 3:03 PM
varun requested review of this revision.Mar 11 2022, 3:03 PM
ashoat added inline comments.Mar 12 2022, 11:13 AM
server/src/server.js
60

Should the / here (and in similar spots below) be replaced with squadCalBaseRoutePath? I guess you'll have to pull all of that stuff out in a later diff anyways, so it doesn't make sense to update here

varun edited the summary of this revision. (Show Details)Mar 15 2022, 11:21 AM
varun added a parent revision: D3413: choose which app url facts to use based on request url.
varun added a child revision: D3433: [server] add helper function to generate all route paths.
tomek accepted this revision.Mar 16 2022, 6:19 AM
tomek added a reviewer: ashoat.
ashoat accepted this revision.Mar 16 2022, 9:12 PM
This revision is now accepted and ready to land.Mar 16 2022, 9:12 PM
varun marked an inline comment as done.Mar 17 2022, 12:09 PM
Closed by commit rCOMM02dc417d09f4: use landing base route path to construct endpoints (authored by varun). · Explain WhyMar 17 2022, 12:09 PM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMM02dc417d09f4: use landing base route path to construct endpoints.
ashoat added a reverting change: D3550: Revert "use landing base route path to construct endpoints".Mar 29 2022, 3:24 PM
ashoat added a reverting change: rCOMM45d442f00352: Revert "use landing base route path to construct endpoints".Mar 30 2022, 11:15 AM

Revision Contents
Changeset List

PathSize
server/
src/
11 lines

Diff 10318

View Options

server/src/server.js

Loading...