Paths

Table of Contentst

Differential D3420

[services] Add comments about indexes
ClosedPublic
Actions

Authored by • karol on Mar 14 2022, 3:50 PM.

Tags

None

Referenced Files

	F32221186: D3420.1765196987.diff
	Sun, Dec 7, 12:29 PM

Subscribers

Details

Reviewers

tomek
varun
atul
• max
• jim
ashoat

Commits

rCOMM82073b570fb5: [services] Add comments about indexes

Summary

Raised here https://phabricator.ashoat.com/D3087#86770

Adding comments in places where database indexes are needed.

Test Plan

None, these are just comments

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• karol created this revision.Mar 14 2022, 3:50 PM

Herald added subscribers: • benschac, atul, • adrian and 2 others. · View Herald TranscriptMar 14 2022, 3:50 PM

• karol edited the summary of this revision. (Show Details)Mar 14 2022, 3:51 PM

• karol edited the test plan for this revision. (Show Details)

• karol added reviewers: tomek, varun, atul, • max, • jim.

• karol mentioned this in D3087: [services] Backup - Database - add Backup Item.

Harbormaster completed remote builds in B7334: Diff 10335.Mar 14 2022, 3:55 PM

• karol requested review of this revision.Mar 14 2022, 3:55 PM

ashoat requested changes to this revision.Mar 14 2022, 6:12 PM

ashoat added inline comments.

services/backup/docker-server/contents/server/src/DatabaseEntities/BackupItem.h
13–17 ↗	(On Diff #10335)	My initial request was: [comment] clarifying that this class is used for representing two things: the rows in the main table, and also the rows in the secondary index This comment doesn't seem to provide that clarification. Is my understanding correcrt, that `BackupItem` is used for representing both rows in the main table, as well as rows in the secondary index? If so, can you add a comment making that clear?

This revision now requires changes to proceed.Mar 14 2022, 6:12 PM

fix comment

Harbormaster completed remote builds in B7499: Diff 10555.Mar 21 2022, 10:50 AM

ashoat accepted this revision.Mar 21 2022, 2:23 PM

This revision is now accepted and ready to land.Mar 21 2022, 2:23 PM

Closed by commit rCOMM82073b570fb5: [services] Add comments about indexes. · Explain WhyMar 22 2022, 8:40 AM

This revision was automatically updated to reflect the committed changes.

• karol added a commit: rCOMM82073b570fb5: [services] Add comments about indexes.

Revision Contents
Changeset List

Path

Size

services/

backup/

docker-server/

contents/

server/

src/

DatabaseEntities/

10 lines

blob/

docker-server/

contents/

server/

src/

DatabaseEntities/

ReverseIndexItem.h

5 lines

Diff 10587

services/backup/docker-server/contents/server/src/DatabaseEntities/BackupItem.h

Loading...

services/blob/docker-server/contents/server/src/DatabaseEntities/ReverseIndexItem.h

Loading...