Paths

Table of Contentst

-
landing/
1
global.css

[landing] Remove `font-size` in `global.css:html`
ClosedPublic
Actions

Authored by atul on Mar 15 2022, 8:56 AM.

Details

Reviewers

• benschac
tomek
ashoat

Commits

rCOMMd5bde70ac237: [landing] Remove `font-size` in `global.css:html`

Summary

We don't want to set a changing font-size in the root (html selector) because that affects what 1rem is downstream. My understanding is that the root should have 1rem = 16px unless the user modifies their browser settings. We should hold this constant and modify font-size dynamically for <p>, <h1>, etc. because they won't all necessarily scale together linearly. This should make the math simpler.

Subsequent diffs will fix things for each element.

Test Plan

NA, observed that 1rem = 16px

Diff Detail

Repository

rCOMM Comm

Branch

landmarch14 (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Mar 15 2022, 8:56 AM

Herald added subscribers: • karol, • adrian. · View Herald TranscriptMar 15 2022, 8:56 AM

merge background and background-attachment

landing/global.css
17	snuck in this change to use shorthand

Harbormaster completed remote builds in B7380: Diff 10390.Mar 15 2022, 9:01 AM

Harbormaster completed remote builds in B7381: Diff 10391.Mar 15 2022, 9:07 AM

atul requested review of this revision.Mar 15 2022, 9:07 AM

• benschac accepted this revision.Mar 15 2022, 9:35 AM

• benschac added inline comments.

landing/global.css
17	Can you screen shot this? Does it change the purple linear-gradient?

This revision is now accepted and ready to land.Mar 15 2022, 9:35 AM

• benschac added inline comments.Mar 15 2022, 9:35 AM

landing/global.css
17	Actually, think this would be better as its own diff. That's just me.

atul added a child revision: D3432: [landing] Bring back "fluid" `font-size` to `<p>`.Mar 15 2022, 10:43 AM

atul added 1 blocking reviewer(s): ashoat.Mar 15 2022, 1:27 PM

This revision now requires review to proceed.Mar 15 2022, 1:27 PM

atul added a child revision: D3392: [landing] Keep hero `TextLoop` to two lines.Mar 15 2022, 7:05 PM

ashoat accepted this revision.Mar 15 2022, 8:32 PM

This revision is now accepted and ready to land.Mar 15 2022, 8:32 PM

Actually, think this would be better as its own diff. That's just me. (@benschac)

That's fair. I think it's fine to sneak a noop change into a diff now and then if it's in immediate vicinity (in this case the same css selector block) and explicitly flagged for the reviewer, but can be more disciplined about separating things in the future.

rebase before landing

This revision was landed with ongoing or failed builds.Mar 16 2022, 11:49 AM

Closed by commit rCOMMd5bde70ac237: [landing] Remove `font-size` in `global.css:html` (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMMd5bde70ac237: [landing] Remove `font-size` in `global.css:html`.

Harbormaster completed remote builds in B7413: Diff 10436.Mar 16 2022, 11:53 AM

Revision Contents
Changeset List

Path

Size

landing/

global.css

11 lines

Diff 10391

View Options

landing/global.css

Show First 20 Lines • Show All 55 Lines • ▼ Show 20 Lines	networks:
- services-net		- services-net
build:		build:
dockerfile: services/identity/Dockerfile		dockerfile: services/identity/Dockerfile
context: ../		context: ../
image: commapp/identity-server:0.1		image: commapp/identity-server:0.1
container_name: identity-server		container_name: identity-server
ports:		ports:
- "${COMM_SERVICES_PORT_IDENTITY}:50051"		- "${COMM_SERVICES_PORT_IDENTITY}:50051"
		# localstack
		localstack:
		image: localstack/localstack
		container_name: localstack
		hostname: localstack
		ports:
		- "4566:4566"
		environment:
		- SERVICES=s3,dynamodb
		- DATA_DIR=${TMPDIR}/localstack/data
		- HOSTNAME_EXTERNAL=localstack
		volumes:
		jimUnsubmitted Not Done Inline Actions Why bind mount a temp directory instead of using a data volume? It's just gonna create issues with permissions. Also ${TMPDIR} is not used to refer to a path in both the host and the container which is a bad idea. jim: Why bind mount a temp directory instead of using a data volume? It's just gonna create issues…
		- ${TMPDIR}:/tmp/localstack
		networks:
		- services-net

[landing] Remove `font-size` in `global.css:html`ClosedPublicActions