Page MenuHomePhabricator
Differential D3443

[landing] Remove images that are no longer used
ClosedPublic
Actions

Authored by atul on Mar 16 2022, 2:15 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 4, 5:38 PM
Unknown Object (File)
Tue, Sep 24, 3:49 PM
Unknown Object (File)
Tue, Sep 24, 3:49 PM
Unknown Object (File)
Tue, Sep 24, 6:13 AM
Unknown Object (File)
Wed, Sep 18, 4:22 AM
Unknown Object (File)
Wed, Sep 18, 4:22 AM
Unknown Object (File)
Wed, Sep 18, 4:08 AM
Unknown Object (File)
Sep 2 2024, 4:38 AM
View All 99 Files
Subscribers
• adrian
ashoat
• benschac
• karol

Details

Reviewers
• benschac
• jacek
varun
tomek
• jim
Commits
rCOMMffaedd31a94d: [landing] Remove images that are no longer used
Summary

These images were from a previous iteration of the landing page (the vertically paginated scroll-snap one) and are no longer used (did a search of the repo).

The images we currently have on the site live exclusively on S3 and aren't checked into the repo. We might want to do that? (cc @benschac)

Test Plan

Searched through the repo for occurences of these images, and couldn't find any.

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Mar 16 2022, 2:15 PM
Herald added subscribers: • karol, • adrian, ashoat. · View Herald TranscriptMar 16 2022, 2:15 PM
atul published this revision for review.Mar 16 2022, 2:15 PM
Harbormaster completed remote builds in B7429: Diff 10459.Mar 16 2022, 2:20 PM
atul added a reviewer: ashoat.Mar 16 2022, 2:36 PM
• benschac added a comment.Mar 16 2022, 5:40 PM

Yeah, I should have removed them when I worked on it last. Good catch.

• benschac accepted this revision.Mar 16 2022, 5:40 PM
This revision is now accepted and ready to land.Mar 16 2022, 5:40 PM
• benschac added a comment.Mar 16 2022, 5:41 PM

I'd also just double check in asset-meta-data.js in the landing project too.

atul added a child revision: D3445: [web] Remove `div.devices` and associated assets from `Splash` component.Mar 16 2022, 9:10 PM
atul removed a child revision: D3445: [web] Remove `div.devices` and associated assets from `Splash` component.Mar 16 2022, 9:31 PM
atul added 1 blocking reviewer(s): tomek.Mar 16 2022, 9:46 PM
This revision now requires review to proceed.Mar 16 2022, 9:46 PM
atul changed 2 blocking reviewer(s), added 1: ashoat; removed 1: tomek.Mar 17 2022, 8:12 AM
tomek accepted this revision.Mar 17 2022, 9:25 AM
atul removed a reviewer: ashoat.Mar 17 2022, 10:30 AM
This revision is now accepted and ready to land.Mar 17 2022, 10:30 AM
Closed by commit rCOMMffaedd31a94d: [landing] Remove images that are no longer used (authored by atul). · Explain WhyMar 17 2022, 10:56 AM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMMffaedd31a94d: [landing] Remove images that are no longer used.

Revision Contents
Changeset List

Diff 10459

View Options

server/images/customizable-prototype.png

Loading...
View Options

server/images/customizable-prototype.webp

Loading...
View Options

server/images/e2e-encrypted-prototype.png

Loading...
View Options

server/images/e2e-encrypted-prototype.webp

Loading...
View Options

server/images/federated-prototype.png

Loading...
View Options

server/images/federated-prototype.webp

Loading...
View Options

server/images/less-noisy-prototype.png

Loading...
View Options

server/images/less-noisy-prototype.webp

Loading...
View Options

server/images/open-source-prototype.png

Loading...
View Options

server/images/open-source-prototype.webp

Loading...
View Options

server/images/sovereign-prototype.png

Loading...
View Options

server/images/sovereign-prototype.webp

Loading...