[web] [fix] tab color active on active selection
ClosedPublic
Actions

Authored by • benschac on Mar 16 2022, 5:49 PM.

Details

Reviewers

atul
• jacek
tomek
varun

Commits

rCOMM30ef6acce20a: [web] [fix] tab color active on active selection

Summary

Tab should be white, per figma

https://linear.app/comm/issue/ENG-890/tab-selection-color-is-in-de-selected-state-when-selected

https://www.figma.com/file/a1nkbWgbgjRlrOY9LVurTz/Comm-%2F-Desktop-app?node-id=1170%3A79583

Test Plan

change selected color
before:

Image 2022-03-16 at 8.50.23 PM.jpg (628×1 px, 68 KB)

after:

Image 2022-03-16 at 8.50.12 PM.jpg (672×1 px, 72 KB)

Diff Detail

Repository

rCOMM Comm

Branch

fix-tab-settings

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• benschac created this revision.Mar 16 2022, 5:50 PM

Herald added subscribers: • karol, • adrian, tomek, ashoat. · View Herald TranscriptMar 16 2022, 5:50 PM

• benschac edited the summary of this revision. (Show Details)Mar 16 2022, 5:52 PM

• benschac edited the test plan for this revision. (Show Details)

• benschac edited the summary of this revision. (Show Details)

• benschac added reviewers: • jacek, tomek, varun.

Harbormaster completed remote builds in B7439: Diff 10469.Mar 16 2022, 5:55 PM

• benschac requested review of this revision.Mar 16 2022, 5:55 PM

tomek accepted this revision.Mar 17 2022, 10:57 AM

This revision is now accepted and ready to land.Mar 17 2022, 10:57 AM

Closed by commit rCOMM30ef6acce20a: [web] [fix] tab color active on active selection (authored by • benschac). · Explain WhyMar 17 2022, 1:50 PM

This revision was automatically updated to reflect the committed changes.

• benschac added a commit: rCOMM30ef6acce20a: [web] [fix] tab color active on active selection.

Revision Contents
Changeset List

Path

Size

web/

chat/

chat-tabs.css

1 line

Diff 10469

View Options

[web] [fix] tab color active on active selectionClosedPublicActions