Page MenuHomePhabricator

[web] [fix] benjamin/eng-896-color-splotch-wrong-size-currently-40px
ClosedPublic

Authored by benschac on Mar 17 2022, 2:51 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 5, 1:03 AM
Unknown Object (File)
Sun, Oct 20, 6:41 PM
Unknown Object (File)
Thu, Oct 10, 10:57 AM
Unknown Object (File)
Wed, Oct 9, 7:08 PM
Unknown Object (File)
Wed, Oct 9, 7:08 PM
Unknown Object (File)
Wed, Oct 9, 7:07 PM
Unknown Object (File)
Wed, Oct 9, 6:31 PM
Unknown Object (File)
Oct 5 2024, 8:36 AM

Details

Summary

Size bar color splotch is the wrong size https://linear.app/comm/issue/ENG-896/color-splotch-wrong-size-currently-40px-should-be-42px more in linear

before:

Image 2022-03-17 at 5.48.06 PM.jpg (578×962 px, 84 KB)

after:

Image 2022-03-17 at 6.02.48 PM.jpg (634×1 px, 74 KB)

Test Plan

Make it match figma at 42px

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Mar 18 2022, 4:37 AM

This is not an okay diff name. @benschac, we've talked repeatedly before about how we need you to do more to explain your changes to your reviewers. You're moving backwards with these diff names