Page MenuHomePhabricator
Differential D3444

[web] [fix] ENG-730 add notif dot for thread
ClosedPublic
Actions

Authored by • benschac on Mar 16 2022, 2:28 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 15, 11:18 PM
Unknown Object (File)
Thu, Nov 14, 4:32 PM
Unknown Object (File)
Thu, Nov 14, 8:53 AM
Unknown Object (File)
Wed, Nov 13, 12:42 PM
Unknown Object (File)
Tue, Nov 5, 5:34 AM
Unknown Object (File)
Oct 9 2024, 7:08 PM
Unknown Object (File)
Oct 9 2024, 7:08 PM
Unknown Object (File)
Oct 9 2024, 7:07 PM
View All Files
Subscribers
• adrian
ashoat
• karol
tomek

Details

Reviewers
atul
• jacek
tomek
Commits
rCOMMc6f4c30d210e: [web] [fix] ENG-730 add notif dot for thread
Summary

adds notif dot to thread in conversation selector
https://linear.app/comm/issue/ENG-730/unread-indication-for-sidebars-is-very-strange

Image 2022-03-16 at 5.10.59 PM.jpg (1×1 px, 122 KB)

Test Plan

send your self a message from one user to another, click sidebar to toggle off unread.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• benschac created this revision.Mar 16 2022, 2:28 PM
Herald added subscribers: • karol, • adrian, tomek, ashoat. · View Herald TranscriptMar 16 2022, 2:28 PM
• benschac edited the summary of this revision. (Show Details)Mar 16 2022, 2:28 PM
• benschac added a parent revision: D3441: [web] [fix] align unread buttons.
Harbormaster completed remote builds in B7430: Diff 10460.Mar 16 2022, 2:33 PM
• benschac requested review of this revision.Mar 16 2022, 2:33 PM
• benschac edited the summary of this revision. (Show Details)Mar 16 2022, 2:46 PM
atul added reviewers: • jacek, tomek.Mar 16 2022, 3:13 PM
atul accepted this revision.Mar 16 2022, 9:59 PM

Looks good! small note inline

web/chat/chat-thread-list-sidebar.react.js
19–20 ↗(On Diff #10460)

Looks like we're pulling two things out of threadInfo. Could we do something like

const { id: threadID, currentUser } = threadInfo;

?

I think we could also do something like:

const { id: threadID, currentUser: {unread} } = threadInfo;

but that would maybe be too crazy

This revision is now accepted and ready to land.Mar 16 2022, 9:59 PM
• benschac added a child revision: D3454: [web] [fix] ENG-895 Chat Thread List Menu button and time doesn't match design.Mar 17 2022, 1:38 PM
• benschac updated this revision to Diff 10672.Mar 24 2022, 1:16 PM

atul diff suggestions

web/chat/chat-thread-list-sidebar.react.js
19–20 ↗(On Diff #10460)

i got crazy.

Harbormaster completed remote builds in B7597: Diff 10672.Mar 24 2022, 1:20 PM
• benschac retitled this revision from [web] [fix] add notif dot for thread ENG-730 to [web] [fix] ENG-730 add notif dot for thread.Mar 29 2022, 8:37 AM
atul added a comment.Mar 30 2022, 12:55 PM

Can this be landed?

• benschac added a comment.Mar 30 2022, 1:51 PM

not yet. Waiting on the arrow.

• benschac added a comment.Apr 1 2022, 11:03 AM

These are blocked by getting longer arrow svgs

Image 2022-04-01 at 2.02.43 PM.jpg (368×962 px, 31 KB)

atul added a comment.Apr 1 2022, 11:09 AM
In D3444#98393, @benschac wrote:

These are blocked by getting longer arrow svgs

Image 2022-04-01 at 2.02.43 PM.jpg (368×962 px, 31 KB)

How much longer did you want the arrow?

• benschac added a comment.Apr 1 2022, 11:12 AM
In D3444#98394, @atul wrote:
In D3444#98393, @benschac wrote:

These are blocked by getting longer arrow svgs

Image 2022-04-01 at 2.02.43 PM.jpg (368×962 px, 31 KB)

How much longer did you want the arrow?

10px should do it.

atul added a comment.Apr 1 2022, 11:14 AM
In D3444#98396, @benschac wrote:
In D3444#98394, @atul wrote:
In D3444#98393, @benschac wrote:

These are blocked by getting longer arrow svgs

Image 2022-04-01 at 2.02.43 PM.jpg (368×962 px, 31 KB)

How much longer did you want the arrow?

10px should do it.

https://blob.sh/atul/long_arrow.svg

• benschac updated this revision to Diff 11433.Apr 13 2022, 10:31 AM

rebase

Harbormaster completed remote builds in B8168: Diff 11433.Apr 13 2022, 10:40 AM
Closed by commit rCOMMc6f4c30d210e: [web] [fix] ENG-730 add notif dot for thread (authored by • benschac). · Explain WhyApr 19 2022, 9:51 AM
This revision was automatically updated to reflect the committed changes.
• benschac added a commit: rCOMMc6f4c30d210e: [web] [fix] ENG-730 add notif dot for thread.

Revision Contents
Changeset List

Diff 11620

View Options

web/chat/chat-thread-list-sidebar.react.js

Loading...
View Options

web/chat/chat-thread-list.css

Loading...