Page MenuHomePhabricator
Differential D3493

[web] [refactor] move props to single destructure in top of chat thread list item menu component
ClosedPublic
Actions

Authored by • benschac on Mar 23 2022, 6:42 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 12, 2:49 AM
Unknown Object (File)
Mon, Mar 10, 2:21 AM
Unknown Object (File)
Mon, Mar 10, 2:21 AM
Unknown Object (File)
Mon, Mar 10, 2:17 AM
Unknown Object (File)
Mon, Mar 10, 2:15 AM
Unknown Object (File)
Feb 3 2025, 10:42 AM
Unknown Object (File)
Jan 31 2025, 8:14 AM
Unknown Object (File)
Jan 25 2025, 2:37 AM
View All Files
Subscribers
• adrian
ashoat
• karol
tomek

Details

Reviewers
atul
Commits
rCOMMa5cee196b7a6: [web] [refactor] move props to single destructure in top of chat thread list…
Summary

move props destructure to one place

Test Plan

N/A - shouldn't get any flow errors. Page should render normally

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• benschac created this revision.Mar 23 2022, 6:42 AM
Herald added subscribers: • karol, • adrian, tomek, ashoat. · View Herald TranscriptMar 23 2022, 6:42 AM
• benschac added a parent revision: D3422: [web] [fix] style mark as unread.Mar 23 2022, 6:43 AM
Harbormaster completed remote builds in B7534: Diff 10603.Mar 23 2022, 6:47 AM
• benschac requested review of this revision.Mar 23 2022, 6:47 AM
• benschac added a child revision: D3499: [web] [feat] add mark as unread styles for selected and hovered states.Mar 23 2022, 8:14 AM
atul added a comment.Mar 23 2022, 9:44 AM

N/A - should get any flow error

nit: think you mean *shouldn't?

atul accepted this revision.Mar 23 2022, 9:45 AM
This revision is now accepted and ready to land.Mar 23 2022, 9:45 AM
• benschac edited the test plan for this revision. (Show Details)Mar 23 2022, 10:01 AM
In D3493#95153, @atul wrote:

N/A - should get any flow error

nit: think you mean *shouldn't?

ty

Closed by commit rCOMMa5cee196b7a6: [web] [refactor] move props to single destructure in top of chat thread list… (authored by • benschac). · Explain WhyMar 24 2022, 12:30 PM
This revision was automatically updated to reflect the committed changes.
• benschac added a commit: rCOMMa5cee196b7a6: [web] [refactor] move props to single destructure in top of chat thread list….

Revision Contents
Changeset List

PathSize
web/
chat/
4 lines

Diff 10669

View Options

web/chat/chat-thread-list-item-menu.react.js

Loading...