[services] Dev Mode - Apply local cloud to the Backup service
AbandonedPublic
Actions

Authored by • karol on Mar 23 2022, 7:58 AM.

Details

Reviewers

• jim
• max
varun
tomek

Summary

Depends on D3497

This replaces the old approach to the dev mode in the backup service with the local cloud.

Test Plan

cd services
yarn run-local-cloud
yarn setup-local-cloud
yarn run-backup-service-dev-mode

Diff Detail

Repository

rCOMM Comm

Branch

localstack

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• karol created this revision.Mar 23 2022, 7:58 AM

Herald added subscribers: • benschac, atul, • adrian and 2 others. · View Herald TranscriptMar 23 2022, 7:58 AM

• karol edited the summary of this revision. (Show Details)Mar 23 2022, 8:12 AM

• karol edited the test plan for this revision. (Show Details)

• karol added reviewers: • jim, • max, varun, tomek.

• karol added a parent revision: D3497: [services] Dev Mode - Apply local cloud to the Blob service.

Harbormaster completed remote builds in B7539: Diff 10608.Mar 23 2022, 8:12 AM

• karol requested review of this revision.Mar 23 2022, 8:12 AM

• karol edited the test plan for this revision. (Show Details)Mar 23 2022, 8:15 AM

• karol added a child revision: D3523: [services] Backup/Blob - fix test path.Mar 25 2022, 5:04 AM

Putting @jimpo as blocking to make sure we're thinking about Docker / Docker Compose correctly

• jim requested changes to this revision.Apr 4 2022, 1:33 PM

• jim added inline comments.

services/backup/docker-server/contents/server/src/AwsTools.cpp
10	I don't like that this is a compile-time flag. This is runtime configuration. It'd be better to load this from an actual AWS config file or other type of config file, or at the very least command line options or environment variable.

This revision now requires changes to proceed.Apr 4 2022, 1:33 PM

• jim mentioned this in D3497: [services] Dev Mode - Apply local cloud to the Blob service.Apr 4 2022, 1:35 PM

• karol added inline comments.Apr 11 2022, 1:51 AM

services/backup/docker-server/contents/server/src/AwsTools.cpp
10	We have to read this from the command line. It cannot be read from any config file. The parameters in config files are constant. And having the same files' state we want to be able to run both normal mode and dev mode. If we want to avoid compiler flags, I think we need to read the environment variables in the c++ code in the runtime. Reading it from the command line arguments doesn't seem like a good idea - this will not scale well. If the number of such parameters grows, the code's going to get quite messy.

I changed my approach, now I used terraform for this. I'm abandoning this one. I decided that it will be faster to set up a new stack as I reordered the diffs and a lot of the differed from the ones from this stack. Let's follow up in the stack beginning at D3695.

• karol mentioned this in D3690: [services] Dev mode - Set up Backup service.Apr 11 2022, 6:47 AM

• karol mentioned this in D3872: [services] Blob/Backup - Read env vars in runtime instead of compile-time flags.Apr 28 2022, 2:39 AM

• karol mentioned this in rCOMM010fcaa64933: [services] Blob/Backup - Read env vars in runtime instead of compile-time flags.May 6 2022, 1:46 AM