[web] [feat] add mark as unread styles for selected and hovered states
ClosedPublic
Actions

Authored by • benschac on Mar 23 2022, 8:13 AM.

Details

Reviewers

atul
tomek
• jacek
ashoat

Commits

rCOMMc2358a3f9af8: [web] [feat] add mark as unread styles for selected and hovered states

Summary

per conversation in D3422 updating active and hovered styles for mark as unread (this is option 1)

Image 2022-03-22 at 9.35.04 AM.jpg (910×893 px, 218 KB)

https://linear.app/comm/issue/ENG-733/mark-as-read-button-has-white-text-on-light-background-when-thread-is

Screen Recording 2022-03-23 at 11.17.50 AM.gif (501×1 px, 4 MB)

Test Plan

hover and select chat thread list items, click mark as unread menu button. Make sure they match.

Diff Detail

Repository

rCOMM Comm

Branch

fix-hover-background-color

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• benschac created this revision.Mar 23 2022, 8:13 AM

Herald added subscribers: • karol, • adrian, tomek, ashoat. · View Herald TranscriptMar 23 2022, 8:13 AM

• benschac added reviewers: tomek, • jacek.Mar 23 2022, 8:14 AM

• benschac added a parent revision: D3493: [web] [refactor] move props to single destructure in top of chat thread list item menu component.

Harbormaster completed remote builds in B7540: Diff 10609.Mar 23 2022, 8:18 AM

• benschac requested review of this revision.Mar 23 2022, 8:18 AM

• benschac edited the summary of this revision. (Show Details)Mar 23 2022, 8:18 AM

• benschac edited the summary of this revision. (Show Details)

add space

• benschac edited the summary of this revision. (Show Details)Mar 23 2022, 8:23 AM

• benschac edited the summary of this revision. (Show Details)

• benschac added a reviewer: ashoat.

adding ashoat as a reviewer since we ah-hoc designed mark as unread and want this to be in your queue. Feel free to remove yourself if it's not relevant.

Harbormaster completed remote builds in B7543: Diff 10612.Mar 23 2022, 8:29 AM

• benschac added a child revision: D3500: [web] [refactor] css color should be white.Mar 23 2022, 10:22 AM

It's kind of hard for me to tell what's going on between D3422 and this diff. I'm not sure what the visual repercussions are here, and why there need to be two diffs (what does the second diff do). But I guess it looks good?

It seems like the easiest way for me to review this is just to get it landed and see what it looks like on prod. Another reason to prioritize ENG-889.

This revision is now accepted and ready to land.Mar 23 2022, 8:34 PM

Closed by commit rCOMMc2358a3f9af8: [web] [feat] add mark as unread styles for selected and hovered states (authored by • benschac). · Explain WhyMar 24 2022, 12:30 PM

This revision was automatically updated to reflect the committed changes.

• benschac added a commit: rCOMMc2358a3f9af8: [web] [feat] add mark as unread styles for selected and hovered states.