Page MenuHomePhabricator

[web] [refactor] simplify username logic in message preview
ClosedPublic

Authored by benschac on Mar 23 2022, 12:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 19, 2:39 PM
Unknown Object (File)
Sat, Apr 19, 12:32 PM
Unknown Object (File)
Sat, Apr 19, 10:05 AM
Unknown Object (File)
Sat, Apr 19, 7:56 AM
Unknown Object (File)
Sat, Apr 19, 4:36 AM
Unknown Object (File)
Sat, Apr 19, 2:50 AM
Unknown Object (File)
Sat, Apr 19, 2:49 AM
Unknown Object (File)
Fri, Apr 18, 8:28 PM

Details

Summary

simplify rendering logic for username in message preview

Test Plan

username logic is the same as production. No new functionality

Diff Detail

Repository
rCOMM Comm
Branch
fix-hover-background-color
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

benschac added inline comments.
web/chat/message-preview.react.js
50 ↗(On Diff #10632)

This logic is wrong.

ashoat added inline comments.
web/chat/message-preview.react.js
28 ↗(On Diff #10665)

Let's move this closer to where it's used. Line 48 makes the most sense

This revision is now accepted and ready to land.Mar 24 2022, 6:02 PM