Page MenuHomePhabricator
Differential D3506

[web] [refactor] simplify username logic in message preview
ClosedPublic
Actions

Authored by • benschac on Mar 23 2022, 12:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 19, 2:39 PM
Unknown Object (File)
Sat, Apr 19, 12:32 PM
Unknown Object (File)
Sat, Apr 19, 10:05 AM
Unknown Object (File)
Sat, Apr 19, 7:56 AM
Unknown Object (File)
Sat, Apr 19, 4:36 AM
Unknown Object (File)
Sat, Apr 19, 2:50 AM
Unknown Object (File)
Sat, Apr 19, 2:49 AM
Unknown Object (File)
Fri, Apr 18, 8:28 PM
View All Files
Subscribers
• adrian
ashoat
• karol
tomek

Details

Reviewers
atul
• jacek
tomek
ashoat
Commits
rCOMM426e725ba042: [web] [refactor] simplify username logic in message preview
Summary

simplify rendering logic for username in message preview

Test Plan

username logic is the same as production. No new functionality

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• benschac created this revision.Mar 23 2022, 12:33 PM
Herald added subscribers: • karol, • adrian, tomek, ashoat. · View Herald TranscriptMar 23 2022, 12:33 PM
• benschac added a parent revision: D3505: [web] [refactor] message preview styles solidified into one ternary statement.Mar 23 2022, 12:34 PM
Harbormaster completed remote builds in B7558: Diff 10629.Mar 23 2022, 12:38 PM
• benschac requested review of this revision.Mar 23 2022, 12:38 PM
• benschac updated this revision to Diff 10631.Mar 23 2022, 12:41 PM

make hasUserName const

• benschac updated this revision to Diff 10632.Mar 23 2022, 12:42 PM

remove hasUsername const

Harbormaster completed remote builds in B7560: Diff 10631.Mar 23 2022, 12:46 PM
Harbormaster completed remote builds in B7561: Diff 10632.Mar 23 2022, 12:48 PM
• benschac added a child revision: D3508: [web] [refactor] move hasUsername logic to variable.Mar 23 2022, 1:08 PM
• benschac added reviewers: • jacek, tomek.Mar 23 2022, 1:55 PM
• benschac planned changes to this revision.Mar 24 2022, 5:20 AM
• benschac added inline comments.
web/chat/message-preview.react.js
50 ↗(On Diff #10632)

This logic is wrong.

• benschac updated this revision to Diff 10665.Mar 24 2022, 9:17 AM

fix logic

Harbormaster completed remote builds in B7594: Diff 10665.Mar 24 2022, 9:22 AM
ashoat accepted this revision.Mar 24 2022, 6:02 PM
ashoat added inline comments.
web/chat/message-preview.react.js
28

Let's move this closer to where it's used. Line 48 makes the most sense

This revision is now accepted and ready to land.Mar 24 2022, 6:02 PM
• benschac updated this revision to Diff 10684.Mar 25 2022, 7:32 AM

diff review

Harbormaster completed remote builds in B7608: Diff 10684.Mar 25 2022, 7:58 AM
• benschac updated this revision to Diff 10704.Mar 25 2022, 10:37 AM

rebase

Harbormaster completed remote builds in B7622: Diff 10704.Mar 25 2022, 10:42 AM
Closed by commit rCOMM426e725ba042: [web] [refactor] simplify username logic in message preview (authored by • benschac). · Explain WhyMar 25 2022, 10:55 AM
This revision was automatically updated to reflect the committed changes.
• benschac added a commit: rCOMM426e725ba042: [web] [refactor] simplify username logic in message preview.

Revision Contents
Changeset List

PathSize
web/
chat/
38 lines

Diff 10665

View Options

web/chat/message-preview.react.js

Show All 27 Lines
import { import {
fullStateSyncActionType, fullStateSyncActionType,
incrementalStateSyncActionType, incrementalStateSyncActionType,
} from '../types/socket-types.js'; } from '../types/socket-types.js';
import { updateTypes } from '../types/update-types-enum.js'; import { updateTypes } from '../types/update-types-enum.js';
import { processUpdatesActionType } from '../types/update-types.js'; import { processUpdatesActionType } from '../types/update-types.js';
import type { CurrentUserInfo, UserStore } from '../types/user-types.js'; import type { CurrentUserInfo, UserStore } from '../types/user-types.js';
import { setNewSessionActionType } from '../utils/action-utils.js'; import { setNewSessionActionType } from '../utils/action-utils.js';
import { getMessageForException } from '../utils/errors.js';
import { assertObjectsAreEqual } from '../utils/objects.js';
function reduceCurrentUserInfo( function reduceCurrentUserInfo(
state: ?CurrentUserInfo, state: ?CurrentUserInfo,
action: BaseAction, action: BaseAction,
): ?CurrentUserInfo { ): ?CurrentUserInfo {
if ( if (
action.type === logInActionTypes.success || action.type === logInActionTypes.success ||
action.type === siweAuthActionTypes.success || action.type === siweAuthActionTypes.success ||
▲ Show 20 Lines • Show All 71 Lines • ▼ Show 20 Lines if (state?.settings) {
}; };
} }
} else if (action.type === resetUserStateActionType) { } else if (action.type === resetUserStateActionType) {
state = state && state.anonymous ? state : null; state = state && state.anonymous ? state : null;
} }
return state; return state;
} }
// eslint-disable-next-line no-unused-vars
function assertUserStoresAreEqual(
processedUserStore: UserStore,
expectedUserStore: UserStore,
location: string,
onStateDifference: (message: string) => mixed,
) {
try {
assertObjectsAreEqual(
processedUserStore,
expectedUserStore,
`UserStore - ${location}`,
);
} catch (e) {
const message = `Error processing UserStore ops ${
kamilAuthorUnsubmitted
Done
Inline Actions

UserStore here is probably redundant (look at screenshots)

kamil: `UserStore` here is probably redundant (look at screenshots)
getMessageForException(e) ?? '{no exception message}'
}`;
onStateDifference(message);
}
}
function reduceUserInfos( function reduceUserInfos(
state: UserStore, state: UserStore,
action: BaseAction, action: BaseAction,
// eslint-disable-next-line no-unused-vars
kamilAuthorUnsubmitted
Done
Inline Actions

I'll remove those in the next diff (here and line 125)

kamil: I'll remove those in the next diff (here and line 125)
onStateDifference: (message: string) => mixed,
): [UserStore, $ReadOnlyArray<UserInconsistencyReportCreationRequest>] { ): [UserStore, $ReadOnlyArray<UserInconsistencyReportCreationRequest>] {
if ( if (
action.type === joinThreadActionTypes.success || action.type === joinThreadActionTypes.success ||
action.type === newThreadActionTypes.success action.type === newThreadActionTypes.success
) { ) {
const newUserInfos = _keyBy(userInfo => userInfo.id)( const newUserInfos = _keyBy(userInfo => userInfo.id)(
action.payload.userInfos, action.payload.userInfos,
); );
▲ Show 20 Lines • Show All 121 Lines • Show Last 20 Lines