Page MenuHomePhabricator

[web] [refactor] move hasUsername logic to variable
ClosedPublic

Authored by benschac on Mar 23 2022, 1:03 PM.
Tags
None
Referenced Files
F5108192: D3508.id10685.diff
Tue, Apr 1, 1:12 PM
Unknown Object (File)
Mon, Mar 31, 10:00 PM
Unknown Object (File)
Mon, Mar 31, 4:16 AM
Unknown Object (File)
Sun, Mar 30, 9:58 PM
Unknown Object (File)
Sun, Mar 30, 8:00 PM
Unknown Object (File)
Sun, Mar 30, 2:32 PM
Unknown Object (File)
Sat, Mar 29, 6:51 PM
Unknown Object (File)
Fri, Mar 28, 6:30 PM

Details

Summary

move logic to variable thats descriptive of what it checks for

Image 2022-03-23 at 4.05.10 PM.jpg (1×3 px, 350 KB)

Image 2022-03-23 at 4.05.25 PM.jpg (2×2 px, 363 KB)

Test Plan

no new added functionality, username should render as normal

Diff Detail

Repository
rCOMM Comm
Branch
fix-hover-background-color
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat requested changes to this revision.Mar 23 2022, 8:40 PM

This is absolutely not the same logic

This revision now requires changes to proceed.Mar 23 2022, 8:40 PM
This revision is now accepted and ready to land.Mar 24 2022, 6:03 PM