Page MenuHomePhabricator
Differential D3508

[web] [refactor] move hasUsername logic to variable
ClosedPublic
Actions

Authored by • benschac on Mar 23 2022, 1:03 PM.
Tags
None
Referenced Files
F3378427: D3508.diff
Wed, Nov 27, 10:30 AM
Unknown Object (File)
Sun, Nov 17, 1:34 AM
Unknown Object (File)
Fri, Nov 15, 6:07 AM
Unknown Object (File)
Thu, Nov 14, 6:20 PM
Unknown Object (File)
Thu, Nov 14, 4:34 PM
Unknown Object (File)
Thu, Nov 14, 4:34 PM
Unknown Object (File)
Thu, Nov 14, 4:34 PM
Unknown Object (File)
Sat, Nov 2, 8:04 AM
View All Files
Subscribers
• adrian
ashoat
• karol
tomek

Details

Reviewers
atul
tomek
• jacek
ashoat
Commits
rCOMMcf4fd35e30c5: [web] [refactor] move hasUsername logic to variable
Summary

move logic to variable thats descriptive of what it checks for

Image 2022-03-23 at 4.05.10 PM.jpg (1×3 px, 350 KB)

Image 2022-03-23 at 4.05.25 PM.jpg (2×2 px, 363 KB)

Test Plan

no new added functionality, username should render as normal

Diff Detail

Repository
rCOMM Comm
Branch
fix-hover-background-color
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• benschac created this revision.Mar 23 2022, 1:03 PM
Herald added subscribers: • karol, • adrian, tomek, ashoat. · View Herald TranscriptMar 23 2022, 1:03 PM
• benschac edited the summary of this revision. (Show Details)Mar 23 2022, 1:07 PM
• benschac added a parent revision: D3506: [web] [refactor] simplify username logic in message preview.
Harbormaster completed remote builds in B7562: Diff 10633.Mar 23 2022, 1:08 PM
• benschac requested review of this revision.Mar 23 2022, 1:08 PM
• benschac added a child revision: D3509: [web] [refactor] update message info ternary to if else, to match codebase convention.Mar 23 2022, 1:15 PM
• benschac added reviewers: tomek, • jacek.Mar 23 2022, 1:55 PM
ashoat requested changes to this revision.Mar 23 2022, 8:40 PM

This is absolutely not the same logic

This revision now requires changes to proceed.Mar 23 2022, 8:40 PM
• benschac updated this revision to Diff 10666.Mar 24 2022, 9:31 AM

rebase

Harbormaster completed remote builds in B7595: Diff 10666.Mar 24 2022, 9:36 AM
ashoat accepted this revision.Mar 24 2022, 6:03 PM

Makes sense now

This revision is now accepted and ready to land.Mar 24 2022, 6:03 PM
• benschac updated this revision to Diff 10685.Mar 25 2022, 7:40 AM

rebase

Harbormaster completed remote builds in B7609: Diff 10685.Mar 25 2022, 8:07 AM
• benschac updated this revision to Diff 10706.Mar 25 2022, 11:06 AM

rebase

Harbormaster completed remote builds in B7623: Diff 10706.Mar 25 2022, 11:11 AM
Closed by commit rCOMMcf4fd35e30c5: [web] [refactor] move hasUsername logic to variable (authored by • benschac). · Explain WhyMar 25 2022, 11:16 AM
This revision was automatically updated to reflect the committed changes.
• benschac added a commit: rCOMMcf4fd35e30c5: [web] [refactor] move hasUsername logic to variable.

Revision Contents
Changeset List

PathSize
web/
chat/
9 lines

Diff 10633

View Options

web/chat/message-preview.react.js

Loading...