Paths

Table of Contentst

[web] Change `Button` component color on hover
ClosedPublic
Actions

Authored by atul on Mar 29 2022, 6:41 PM.

Details

Reviewers

tomek
• jacek
• benschac

Commits

rCOMMcad5d9559458: [web] Change `Button` component color on hover

Summary

I looked through Figma and couldn't find any buttons in the "hover" state... but I still think buttons should change color on hover and it feels unnatural when they don't.

The button background was --violet-dark-100, so I went with --violet-dark-80 for background color on hover for now

Test Plan

Looks as expected:

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Mar 29 2022, 6:41 PM

Herald added subscribers: • abosh, • karol, • adrian, ashoat. · View Herald TranscriptMar 29 2022, 6:41 PM

atul published this revision for review.Mar 29 2022, 6:41 PM

atul edited the test plan for this revision. (Show Details)

Harbormaster completed remote builds in B7703: Diff 10805.Mar 29 2022, 6:47 PM

tomek accepted this revision.Mar 30 2022, 3:17 AM

This revision is now accepted and ready to land.Mar 30 2022, 3:17 AM

rebase before landing

This revision was landed with ongoing or failed builds.Mar 30 2022, 9:30 AM

Closed by commit rCOMMcad5d9559458: [web] Change `Button` component color on hover (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMMcad5d9559458: [web] Change `Button` component color on hover.

Harbormaster completed remote builds in B7723: Diff 10825.Mar 30 2022, 9:33 AM

Revision Contents
Changeset List

Path

Size

web/

components/

button.css

6 lines

theme.css

1 line

Diff 10805

View Options

web/components/button.css