Page MenuHomePhabricator
Differential D3557

[web] Change `Button` component color on hover
ClosedPublic
Actions

Authored by atul on Mar 29 2022, 6:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 21, 10:10 PM
Unknown Object (File)
Mon, Apr 21, 10:10 PM
Unknown Object (File)
Sat, Apr 19, 7:28 AM
Unknown Object (File)
Sat, Apr 19, 4:24 AM
Unknown Object (File)
Sat, Apr 19, 12:43 AM
Unknown Object (File)
Fri, Apr 18, 6:55 PM
Unknown Object (File)
Fri, Apr 18, 2:40 PM
Unknown Object (File)
Mon, Apr 14, 2:01 AM
View All Files
Subscribers
• abosh
• adrian
ashoat
• karol

Details

Reviewers
tomek
• jacek
• benschac
Commits
rCOMMcad5d9559458: [web] Change `Button` component color on hover
Summary

I looked through Figma and couldn't find any buttons in the "hover" state... but I still think buttons should change color on hover and it feels unnatural when they don't.

The button background was --violet-dark-100, so I went with --violet-dark-80 for background color on hover for now

Test Plan

Looks as expected:

Diff Detail

Repository
rCOMM Comm
Branch
landmarch30 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Mar 29 2022, 6:41 PM
Herald added subscribers: • abosh, • karol, • adrian, ashoat. · View Herald TranscriptMar 29 2022, 6:41 PM
atul published this revision for review.Mar 29 2022, 6:41 PM
atul edited the test plan for this revision. (Show Details)
Harbormaster completed remote builds in B7703: Diff 10805.Mar 29 2022, 6:47 PM
tomek accepted this revision.Mar 30 2022, 3:17 AM
This revision is now accepted and ready to land.Mar 30 2022, 3:17 AM
atul updated this revision to Diff 10825.Mar 30 2022, 9:27 AM

rebase before landing

This revision was landed with ongoing or failed builds.Mar 30 2022, 9:30 AM
Closed by commit rCOMMcad5d9559458: [web] Change `Button` component color on hover (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMMcad5d9559458: [web] Change `Button` component color on hover.
Harbormaster completed remote builds in B7723: Diff 10825.Mar 30 2022, 9:33 AM

Revision Contents
Changeset List

PathSize
web/
components/
6 lines
1 line

Diff 10825

View Options

web/components/button.css

import ExpoModulesCore import ExpoModulesCore
import CryptoKit
public class AESCryptoModule: Module { public class AESCryptoModule: Module {
public func definition() -> ModuleDefinition { public func definition() -> ModuleDefinition {
Name("AESCrypto") Name("AESCrypto")
Function("hello") { () -> String in Function("generateKey", generateKey)
return "Hello world! 👋"
} }
} }
// MARK: - Function implementations
private func generateKey(destination: Uint8Array) throws {
let key = SymmetricKey(size: .bits256)
guard destination.byteLength * 8 == key.bitCount else {
throw InvalidKeyLengthException()
}
atulUnsubmitted
Not Done
Inline Actions

Before we even generate key via SymmetricKey, should we check that destination.byteLength is 32 and throw InvalidDestinationSizeException() if not?

It seems like destination is the input that we want to validate, so we should just do that directly? It's not really so much that SymmetricKey is giving us incorrect size key since it's (I'm assuming) always going to give us exactly the size we're asking for?

Feel free to re-request review if there's something I'm missing here.

atul: Before we even generate `key` via `SymmetricKey`, should we check that `destination.byteLength`…
bartekAuthorUnsubmitted
Done
Inline Actions

The only reason the guard is below SymmetricKey is that I wanted to use its bitCount property to get the desired destination length, but you're right that it can be done this way:

guard destination.byteLength == KEY_SIZE else {
  throw InvalidKeyLengthException()
}
let key = SymmetricKey(size: .bits256)

I'll refactor this as it is more clear solution

bartek: The only reason the guard is below `SymmetricKey` is that I wanted to use its `bitCount`…
key.withUnsafeBytes { bytes in
let _ = bytes.copyBytes(to: destination.rawBufferPtr())
}
}
// MARK: - Utilities
extension TypedArray {
func rawBufferPtr() -> UnsafeMutableRawBufferPointer {
UnsafeMutableRawBufferPointer(start: self.rawPointer,
count: self.byteLength)
}
}
// MARK: - Exception definitions
private class InvalidKeyLengthException: Exception {
override var reason: String {
"The AES key has invalid length"
}
} }
View Options

web/theme.css

import ExpoModulesCore import ExpoModulesCore
import CryptoKit
public class AESCryptoModule: Module { public class AESCryptoModule: Module {
public func definition() -> ModuleDefinition { public func definition() -> ModuleDefinition {
Name("AESCrypto") Name("AESCrypto")
Function("hello") { () -> String in Function("generateKey", generateKey)
return "Hello world! 👋"
} }
} }
// MARK: - Function implementations
private func generateKey(destination: Uint8Array) throws {
let key = SymmetricKey(size: .bits256)
guard destination.byteLength * 8 == key.bitCount else {
throw InvalidKeyLengthException()
}
atulUnsubmitted
Not Done
Inline Actions

Before we even generate key via SymmetricKey, should we check that destination.byteLength is 32 and throw InvalidDestinationSizeException() if not?

It seems like destination is the input that we want to validate, so we should just do that directly? It's not really so much that SymmetricKey is giving us incorrect size key since it's (I'm assuming) always going to give us exactly the size we're asking for?

Feel free to re-request review if there's something I'm missing here.

atul: Before we even generate `key` via `SymmetricKey`, should we check that `destination.byteLength`…
bartekAuthorUnsubmitted
Done
Inline Actions

The only reason the guard is below SymmetricKey is that I wanted to use its bitCount property to get the desired destination length, but you're right that it can be done this way:

guard destination.byteLength == KEY_SIZE else {
  throw InvalidKeyLengthException()
}
let key = SymmetricKey(size: .bits256)

I'll refactor this as it is more clear solution

bartek: The only reason the guard is below `SymmetricKey` is that I wanted to use its `bitCount`…
key.withUnsafeBytes { bytes in
let _ = bytes.copyBytes(to: destination.rawBufferPtr())
}
}
// MARK: - Utilities
extension TypedArray {
func rawBufferPtr() -> UnsafeMutableRawBufferPointer {
UnsafeMutableRawBufferPointer(start: self.rawPointer,
count: self.byteLength)
}
}
// MARK: - Exception definitions
private class InvalidKeyLengthException: Exception {
override var reason: String {
"The AES key has invalid length"
}
} }