migration 0 in migrations.js broke server locally. per the dev environment docs, apache proxies /comm/ to http://localhost:3000/. however, by setting baseRoutePath to basePath, the server was only serving requests for the app at http://localhost:3000/comm/. this diff introduces a new migration to fix commapp_url.json and squadcal_url.json by setting baseRoutePath to /. i've also updated the dev environment docs with the correct baseRoutePath.
Details
Details
ran the migration a few times and checked that:
- if the baseDomain is not "http://localhost", the file is ignored
- if the baseRoutePath is missing, it's added and set to "/" (this is redundant since migration 0 makes sure baseRoutePath exists, but just to be safe...)
- if the baseRoutePath is present, it's changed to "/"
after testing the migration, i also confirmed that i could access the web app locally
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Please address inline comment before landing
| server/src/database/migrations.js | ||
|---|---|---|
| 38–47 ↗ | (On Diff #10848) | This code is messy. It seems like you've made it more complicated than it needs to be, maybe partly due to Flow, but partly from not exiting early. See proposed edit |