[web] Move styles in `style.css` used by `ThreadSettingsModal` to `thread-settings-modal.css`
ClosedPublic
Actions

Authored by atul on Mar 31 2022, 12:01 PM.

Details

Reviewers

tomek
• benschac
• jacek
ashoat

Commits

rCOMM2d116af68312: [web] Move styles in `style.css` used by `ThreadSettingsModal` to `thread…

Summary

Move the styles used by ThreadSettingsModal in style.css to thread-settings-moda.css (if they aren't used elsewhere in repo, in which case they were copied) and "consume" thread-settings-modal.css in ThreadSettingsModal.

This already gets us closer to where we want to be.

Before:

After:

Note: The current-tab, delete-tab and modal-radio selectors are neither in style.css nor in user-settings-modal.css (the file that thread-settings-modal.css was copied from). Will handle styling of these selectors in later diff.

Next diffs:

Remove extraneous selectors from thread-settings-modal.css that aren't used in the ThreadSettingsModal component.
Fill in styles that are "used" by ThreadSettingsModal that don't actually exist anywhere in the repo (eg current-tab). Probably by looking through the git history to see what current-tab used to be.
Style the ThreadSettingsModal component so it looks decent.

Depends on D3589

Test Plan

NA, looks closer to what it used to looks like.

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Mar 31 2022, 12:01 PM

Herald added subscribers: • abosh, • karol, • adrian. · View Herald TranscriptMar 31 2022, 12:01 PM

atul edited the summary of this revision. (Show Details)Mar 31 2022, 12:01 PM

atul added a parent revision: D3589: [web] Copy/paste `user-settings-modal.css` into `thread-settings-modal.css`.

atul edited the summary of this revision. (Show Details)Mar 31 2022, 12:04 PM

Harbormaster completed remote builds in B7784: Diff 10919.Mar 31 2022, 12:09 PM

atul requested review of this revision.Mar 31 2022, 12:09 PM

remove styles that are no longer used in style.css

web/modals/threads/thread-settings-modal.css
145	Can't remove this from `style.css` because it's consumed by `NewThreadModal`.
153	Can't remove this from `style.css` because it's consumed by `NewThreadModal`.
161	Can't remove this from `style.css` because it's consumed by `NewThreadModal`.
165	Can't remove this from `style.css` because it's consumed by `NewThreadModal`.
168	Can't remove this from `style.css` because it's consumed by `NewThreadModal`.
172	Can't remove this from `style.css` because it's consumed by `NewThreadModal`.
178	Can't remove this from `style.css` because it's consumed by `NewThreadModal`.
187	Can't remove this from `style.css` because it's consumed by `NewThreadModal`.
190	Can't remove this from `style.css` because it's consumed by `NewThreadModal`.
194	Searched codebase for `css['italic']` and `css.italic` and didn't find any usages from `style.css`, so this should be safe to delete.

atul retitled this revision from [web] Copy styles in `style.css` used by `ThreadSettingsModal` to `thread-settings-modal.css` to [web] Move styles in `style.css` used by `ThreadSettingsModal` to `thread-settings-modal.css`.Mar 31 2022, 12:20 PM

atul edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B7785: Diff 10920.Mar 31 2022, 12:26 PM

ashoat accepted this revision.Mar 31 2022, 8:56 PM

This revision is now accepted and ready to land.Mar 31 2022, 8:56 PM

It's unfortunate that the regression that broke this styling was ever landed.

rebase before landing

Harbormaster completed remote builds in B7848: Diff 11018.Apr 4 2022, 2:05 PM

Closed by commit rCOMM2d116af68312: [web] Move styles in `style.css` used by `ThreadSettingsModal` to `thread… (authored by atul). · Explain WhyApr 4 2022, 2:18 PM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM2d116af68312: [web] Move styles in `style.css` used by `ThreadSettingsModal` to `thread….