Paths

Table of Contentst

[landing] add profile pictures from s3, remove placehodlr images
AbandonedPublic
Actions

Authored by • benschac on Mar 31 2022, 12:37 PM.

Tags

None

Referenced Files

	F3252833: D3592.diff
	Fri, Nov 15, 6:37 PM

	Unknown Object (File)
	Sun, Nov 10, 12:51 AM

	Unknown Object (File)
	Fri, Nov 8, 10:38 PM

	Unknown Object (File)
	Fri, Nov 8, 1:51 PM

	Unknown Object (File)
	Fri, Oct 18, 4:17 PM

	Unknown Object (File)
	Oct 4 2024, 12:11 PM

	Unknown Object (File)
	Oct 4 2024, 12:11 PM

	Unknown Object (File)
	Oct 4 2024, 12:09 PM

Subscribers

Tokens

"Doubloon" token, awarded by ashoat.

Details

Reviewers

atul

Summary

add s3 images. should render teams head shots

Test Plan

go to /team, headshot should show

Diff Detail

Repository

rCOMM Comm

Branch

team-landing

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• benschac created this revision.Mar 31 2022, 12:37 PM

Herald added subscribers: • abosh, • karol, • adrian and 2 others. · View Herald TranscriptMar 31 2022, 12:37 PM

Harbormaster completed remote builds in B7786: Diff 10921.Mar 31 2022, 12:44 PM

• benschac requested review of this revision.Mar 31 2022, 12:44 PM

• benschac added a parent revision: Restricted Differential Revision.Mar 31 2022, 12:54 PM

At a high level this looks about right, but there's some cleaning up to do before it's ready for review.

landing/team.react.js
12	Shouldn't have commented out code
53	Shouldn't have commented out code.
83–89	Hm, the base of this diff doesn't seem right? Couldn't find a diff in the stack where Varun's `TeamProfile` block was commented out.

This revision now requires changes to proceed.Apr 5 2022, 10:26 AM

"placehodlr" – a true hodler

ashoat awarded a token.Apr 6 2022, 12:19 PM

Closing. Changes from this diff were added to a different diff.

Revision Contents
Changeset List

Path

Size

landing/

team.react.js

77 lines

Diff 10921

View Options

[landing] add profile pictures from s3, remove placehodlr imagesAbandonedPublicActions