Differential D3614
[web] [feat] [ENG-716] update copy on modal for design review Authored by • benschac on Apr 4 2022, 1:48 PM. Tags None Referenced Files
Details update modal copy to match figma copy. Copy isn't correct, the reason I'm adding it to this diff is to make sure the text size and spacing is correct and matches the figma design specification. This copy should either be reverted back to what it currently is, or updated if @ashoat's has feedback. https://www.figma.com/file/a1nkbWgbgjRlrOY9LVurTz/Comm-%2F-Desktop-app?node-id=1303%3A92731 match figma copy: https://linear.app/comm/issue/ENG-716/introduce-leave-channel-modal
Diff Detail
Event TimelineComment Actions Resigning as reviewer since this is a copy change and I don't have any context on that. Personally, think what we already have is better than placeholder copy? Comment Actions This is definitely worse. @benschac, what's your thinking for putting up a change like this up? Please try to think of your role at a higher level – your job isn't to perfectly duplicate the Figma, your job is to make a good web app. This diff is absolutely a regression. You're taking placeholder copy from our Polish language designer at face value. "This and this will happen" is basically lorem ipsum. Comment Actions Thinking: I wanted to make sure I had the right css implemented per the design. The easiest way to do that is take the copy exactly as it's shown and make sure the text, wraps in the exact same place as what's in figma. Using the broken english in the figma, I was able to confirm I had used the correct font size and padding. I too think the previous copy was better. I should have been more specific and explained why I added the lorumipsom here. Comment Actions I can remove this diff from the stack. But, I think matching the content is helpful for visual inspection of styling. Comment Actions I think we should abandon this. Maybe we can talk about it in person if you disagree? Comment Actions Fair enough. I thought it would make visually checking the correctness of the CSS easier / easier review process. If it's making life difficult lets remove it. |