Page MenuHomePhabricator

[services][identity] Add .dockerignore file for Identity Service
ClosedPublic

Authored by varun on Apr 7 2022, 3:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Oct 21, 8:02 PM
Unknown Object (File)
Sat, Oct 19, 8:38 PM
Unknown Object (File)
Sat, Oct 19, 7:11 PM
Unknown Object (File)
Sat, Oct 19, 6:57 PM
Unknown Object (File)
Sat, Oct 19, 6:41 PM
Unknown Object (File)
Sun, Oct 13, 9:19 PM
Unknown Object (File)
Sun, Oct 13, 9:19 PM
Unknown Object (File)
Sun, Oct 13, 9:19 PM

Details

Summary

We don't need to copy some of the files from the identity directory

Depends on D3593

Test Plan

built, ran docker container

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Apr 7 2022, 3:20 PM
Harbormaster failed remote builds in B7998: Diff 11203!
varun requested review of this revision.Apr 8 2022, 7:24 AM
ashoat requested changes to this revision.Apr 10 2022, 7:12 PM

Please delete services/identity/target from the root .gitignore

This revision now requires changes to proceed.Apr 10 2022, 7:12 PM
varun requested review of this revision.Apr 11 2022, 7:49 AM

Please delete services/identity/target from the root .gitignore

This is a .dockerignore file not .gitignore. This is just to avoid copying over unnecessary files to our Docker container.

This revision is now accepted and ready to land.Apr 11 2022, 8:25 AM
This revision was landed with ongoing or failed builds.Apr 11 2022, 1:13 PM
This revision was automatically updated to reflect the committed changes.
services/identity/.dockerignore
4

I don't think this folder should exist outside of the root dir, right?

5

Does a later diff introduce this?