Page MenuHomePhabricator
Differential D3680

[lib] [feat] add useIsomorphicLayoutEffect hook
ClosedPublic
Actions

Authored by • benschac on Apr 10 2022, 8:52 AM.
Tags
None
Referenced Files
F3643585: D3680.id.diff
Sat, Jan 4, 5:22 PM
F3641990: D3680.diff
Sat, Jan 4, 3:26 PM
F3640235: D3680.id.diff
Sat, Jan 4, 11:32 AM
Unknown Object (File)
Sat, Jan 4, 3:42 AM
Unknown Object (File)
Thu, Dec 19, 4:25 AM
Unknown Object (File)
Thu, Dec 19, 4:25 AM
Unknown Object (File)
Thu, Dec 19, 4:25 AM
Unknown Object (File)
Thu, Dec 19, 4:24 AM
View All Files
Subscribers
• abosh
• adrian
ashoat
• karol
tomek

Details

Reviewers
atul
ashoat
Commits
rCOMMee737ed798bf: [lib] [feat] add useIsomorphicLayoutEffect hook
Summary

Add useIsomorphicLayoutEffect hook to lib folder

Test Plan

N/A it's not used yet. It's an exact copy of useIsomorphicLayoutEffect in keyserver.react.js in landing

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• benschac created this revision.Apr 10 2022, 8:52 AM
Herald added subscribers: • abosh, • karol, • adrian and 2 others. · View Herald TranscriptApr 10 2022, 8:52 AM
• benschac added a child revision: D3681: [web] [refactor] [ENG-986] use lib useIsomorphicLayoutEffect.Apr 10 2022, 8:55 AM
Harbormaster completed remote builds in B8043: Diff 11260.Apr 10 2022, 2:47 PM
• benschac requested review of this revision.Apr 10 2022, 2:47 PM
ashoat requested changes to this revision.Apr 10 2022, 7:22 PM
  1. The filename clearly doesn't match conventions in our codebase
  2. Should we update the place this is copied from (in landing) to import from here now?
This revision now requires changes to proceed.Apr 10 2022, 7:22 PM
ashoat added a comment.Apr 10 2022, 7:23 PM

Ah my request #2 above is handled in D3681. I would've made this diff a "factor out" diff, and D3681 the "use in new place" diff. But no need to refactor now

• benschac added a comment.EditedApr 11 2022, 5:54 AM

Sorry about #1. I was working on this late last Friday and I should have spent a bit more time thinking through the diff.

• benschac updated this revision to Diff 11294.Apr 11 2022, 8:25 AM

update file name

Harbormaster completed remote builds in B8075: Diff 11294.Apr 11 2022, 8:30 AM
ashoat accepted this revision.Apr 11 2022, 8:37 AM
This revision is now accepted and ready to land.Apr 11 2022, 8:37 AM
Closed by commit rCOMMee737ed798bf: [lib] [feat] add useIsomorphicLayoutEffect hook (authored by • benschac). · Explain WhyApr 11 2022, 8:43 AM
This revision was automatically updated to reflect the committed changes.
• benschac added a commit: rCOMMee737ed798bf: [lib] [feat] add useIsomorphicLayoutEffect hook.

Revision Contents
Changeset List

PathSize
lib/
hooks/
6 lines

Diff 11297

View Options

lib/hooks/isomorphic-layout-effect.react.js

Loading...