Page MenuHomePhabricator
Differential D3681

[web] [refactor] [ENG-986] use lib useIsomorphicLayoutEffect
ClosedPublic
Actions

Authored by • benschac on Apr 10 2022, 8:54 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 19, 10:29 AM
Unknown Object (File)
Tue, Nov 5, 8:58 PM
Unknown Object (File)
Oct 16 2024, 11:28 PM
Unknown Object (File)
Oct 16 2024, 8:37 AM
Unknown Object (File)
Oct 14 2024, 4:34 PM
Unknown Object (File)
Oct 14 2024, 1:35 AM
Unknown Object (File)
Oct 14 2024, 1:35 AM
Unknown Object (File)
Oct 14 2024, 1:35 AM
View All Files
Subscribers
• abosh
• adrian
ashoat
• karol
tomek

Details

Reviewers
atul
• jacek
tomek
Commits
rCOMM9eff5619b322: [web] [refactor] [ENG-986] use lib useIsomorphicLayoutEffect
Summary

replace useIsomorphicLayoutEffect and React.useLayout effect with lib

Test Plan

console error shouldn't exist anymore from layout effect. Keyserver and menu button work as expected

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• benschac created this revision.Apr 10 2022, 8:54 AM
Herald added subscribers: • abosh, • karol, • adrian and 2 others. · View Herald TranscriptApr 10 2022, 8:54 AM
• benschac added a parent revision: D3680: [lib] [feat] add useIsomorphicLayoutEffect hook.Apr 10 2022, 8:55 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Apr 10 2022, 8:57 AM
Harbormaster failed remote builds in B8044: Diff 11261!
Harbormaster completed remote builds in B8044: Diff 11261.Apr 10 2022, 2:50 PM
• benschac requested review of this revision.Apr 10 2022, 2:50 PM
ashoat mentioned this in D3680: [lib] [feat] add useIsomorphicLayoutEffect hook.Apr 10 2022, 7:23 PM
• benschac updated this revision to Diff 11295.Apr 11 2022, 8:26 AM

rebase

• benschac updated this revision to Diff 11296.Apr 11 2022, 8:28 AM

update import

Harbormaster failed remote builds in B8076: Diff 11295!Apr 11 2022, 8:32 AM
Harbormaster completed remote builds in B8077: Diff 11296.Apr 11 2022, 8:37 AM
ashoat mentioned this in D3678: [web] [fix] [ENG-986] replace useLayoutEffect with useEffect.Apr 11 2022, 8:39 AM
ashoat added reviewers: • jacek, tomek.

Leaving this comment for posterity: some earlier discussion / context on D3678

• benschac added a comment.Apr 11 2022, 8:47 AM

Abandoning D3678 in favor of this diff.

• benschac retitled this revision from [web, landing] [refactor] use lib useIsomorphicLayoutEffect to [web, landing] [refactor] [ENG-986] use lib useIsomorphicLayoutEffect.Apr 11 2022, 1:40 PM
• jacek added a comment.Apr 12 2022, 3:03 AM

@benschac please take a look at my last comment in D3678. The initial solution seems to be ok - it was my mistake. Really sorry for that

• benschac updated this revision to Diff 11351.Apr 12 2022, 8:14 AM

remove menu from diff

• benschac retitled this revision from [web, landing] [refactor] [ENG-986] use lib useIsomorphicLayoutEffect to [web] [refactor] [ENG-986] use lib useIsomorphicLayoutEffect.Apr 12 2022, 8:14 AM
Harbormaster completed remote builds in B8123: Diff 11351.Apr 12 2022, 8:20 AM
tomek accepted this revision.Apr 12 2022, 9:41 AM
• jacek accepted this revision.Apr 13 2022, 2:55 AM
This revision is now accepted and ready to land.Apr 13 2022, 2:55 AM
Closed by commit rCOMM9eff5619b322: [web] [refactor] [ENG-986] use lib useIsomorphicLayoutEffect (authored by • benschac). · Explain WhyApr 13 2022, 5:46 AM
This revision was automatically updated to reflect the committed changes.
• benschac added a commit: rCOMM9eff5619b322: [web] [refactor] [ENG-986] use lib useIsomorphicLayoutEffect.

Revision Contents
Changeset List

PathSize
landing/
5 lines

Diff 11415

View Options

landing/keyservers.react.js

Loading...