Page MenuHomePhabricator
Differential D3688

[services] Tunnelbroker - Database PublicKeyItem tests
ClosedPublic
Actions

Authored by • max on Apr 11 2022, 3:45 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 29, 11:40 AM
Unknown Object (File)
Fri, Nov 15, 5:09 AM
Unknown Object (File)
Thu, Nov 14, 8:58 AM
Unknown Object (File)
Wed, Nov 13, 2:09 AM
Unknown Object (File)
Thu, Nov 7, 5:51 PM
Unknown Object (File)
Sun, Nov 3, 4:07 PM
Unknown Object (File)
Sun, Nov 3, 4:07 PM
Unknown Object (File)
Sun, Nov 3, 4:07 PM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul
• benschac
• karol
tomek

Details

Reviewers
• karol
tomek
varun
Commits
rCOMM8f2c63d89fcb: [services] Tunnelbroker - Database PublicKeyItem tests
Summary

Database (DynamoDB) item tests. For the PublicKeyItem database entity we perform:

  • Check if the table is available,
  • Create and fulfill database item entity,
  • Put into the database table,
  • Find the record using the primary key,
  • Compare record fields of created item and item from database record,
  • Remove the testing record from the database.

Related linear task: ENG-686

Test Plan

Run yarn test-tunnelbroker-service all tests are run and succeed.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• max created this revision.Apr 11 2022, 3:45 AM
Herald added subscribers: • abosh, • benschac, • karol and 4 others. · View Herald TranscriptApr 11 2022, 3:45 AM
• max added a parent revision: D3643: [services] Tunnelbroker - Database item tests initialization.Apr 11 2022, 3:45 AM
• max added reviewers: • karol, tomek, varun.
Harbormaster completed remote builds in B8056: Diff 11275.Apr 11 2022, 3:50 AM
• max requested review of this revision.Apr 11 2022, 3:50 AM
• max mentioned this in D3643: [services] Tunnelbroker - Database item tests initialization.Apr 11 2022, 3:55 AM
tomek requested changes to this revision.Apr 11 2022, 5:20 AM

We also need to clarify our approach to randomness in D3654

services/tunnelbroker/test/DatabaseManagerTest.cpp
39–44 ↗(On Diff #11275)
This revision now requires changes to proceed.Apr 11 2022, 5:20 AM
• max updated this revision to Diff 11287.Apr 11 2022, 6:28 AM

Switch from memcmp to a simple EQ.

• max planned changes to this revision.Apr 11 2022, 6:29 AM
• max marked an inline comment as done.

Switching to the Plan changes until we clarify the random/non-random value for tests.

Harbormaster completed remote builds in B8068: Diff 11287.Apr 11 2022, 6:39 AM
• max updated this revision to Diff 11546.Apr 18 2022, 6:36 AM

Added tests with static variables along with generated ones following D3654#102087.

Harbormaster completed remote builds in B8255: Diff 11546.Apr 18 2022, 6:41 AM
• max updated this revision to Diff 11582.Apr 18 2022, 11:50 PM

Verbose output for generated values in case of failure was added.

Harbormaster completed remote builds in B8286: Diff 11582.Apr 18 2022, 11:59 PM
• max added 1 blocking reviewer(s): tomek.Apr 19 2022, 2:07 AM
tomek requested changes to this revision.Apr 19 2022, 2:33 AM
tomek added inline comments.
services/tunnelbroker/test/DatabaseManagerTest.cpp
26 ↗(On Diff #11582)

We're not testing operations on this item - we're doing that on the db manager and then we verify if it matched the one we've put.

This revision now requires changes to proceed.Apr 19 2022, 2:33 AM
• max planned changes to this revision.Apr 20 2022, 12:41 PM
• max updated this revision to Diff 11699.Apr 21 2022, 1:06 AM

Test names was changed.

• max marked an inline comment as done.Apr 21 2022, 1:06 AM
• max added inline comments.
services/tunnelbroker/test/DatabaseManagerTest.cpp
26 ↗(On Diff #11582)

We're not testing operations on this item - we're doing that on the db manager and then we verify if it matched the one we've put.

Changed the test names to reflect the actions inside.

tomek accepted this revision.Apr 21 2022, 1:10 AM
This revision is now accepted and ready to land.Apr 21 2022, 1:10 AM
Harbormaster completed remote builds in B8387: Diff 11699.Apr 21 2022, 1:10 AM
• max updated this revision to Diff 11846.Apr 25 2022, 5:01 AM
• max marked an inline comment as done.

Rebase on master.

Harbormaster completed remote builds in B8498: Diff 11846.Apr 25 2022, 5:06 AM
Closed by commit rCOMM8f2c63d89fcb: [services] Tunnelbroker - Database PublicKeyItem tests (authored by • max). · Explain WhyApr 25 2022, 5:07 AM
This revision was automatically updated to reflect the committed changes.
• max added a commit: rCOMM8f2c63d89fcb: [services] Tunnelbroker - Database PublicKeyItem tests.

Revision Contents
Changeset List

PathSize
services/
tunnelbroker/
test/
42 lines

Diff 11847

View Options

services/tunnelbroker/test/DatabaseManagerTest.cpp

Loading...