Page MenuHomePhabricator
Differential D3695

[services] Dev mode - Fix Backup service
ClosedPublic
Actions

Authored by • karol on Apr 11 2022, 6:23 AM.
Tags
None
Referenced Files
F3376759: D3695.diff
Wed, Nov 27, 2:01 AM
Unknown Object (File)
Sat, Nov 16, 6:40 AM
Unknown Object (File)
Sat, Nov 16, 6:26 AM
Unknown Object (File)
Fri, Nov 15, 11:26 PM
Unknown Object (File)
Tue, Nov 5, 5:10 PM
Unknown Object (File)
Tue, Nov 5, 5:10 PM
Unknown Object (File)
Tue, Nov 5, 5:10 PM
Unknown Object (File)
Tue, Nov 5, 5:10 PM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul
• benschac
tomek

Details

Reviewers
• jim
tomek
Commits
rCOMMac99b83189cf: [services] Dev mode - Fix Backup service
Summary

Fix dev mode in backup service. Until now it seems like it was broken.

Test Plan
docker-compose down
yarn test-blob-service-dev-mode
yarn test-backup-service-dev-mode

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• karol created this revision.Apr 11 2022, 6:23 AM
Herald added subscribers: • abosh, • benschac, atul and 3 others. · View Herald TranscriptApr 11 2022, 6:23 AM
• karol edited the summary of this revision. (Show Details)Apr 11 2022, 6:24 AM
• karol edited the test plan for this revision. (Show Details)
• karol added reviewers: • jim, tomek.
• karol added a child revision: D3692: [services] Dev mode - Add localstack to docker compose.Apr 11 2022, 6:27 AM
Harbormaster completed remote builds in B8065: Diff 11284.Apr 11 2022, 6:29 AM
• karol requested review of this revision.Apr 11 2022, 6:29 AM
• karol mentioned this in D3495: [services] Dev Mode - create backups for AWS S3 and dynamoDB.Apr 11 2022, 6:43 AM
• karol mentioned this in D3496: [services] Dev Mode - setup local cloud.
• karol mentioned this in D3497: [services] Dev Mode - Apply local cloud to the Blob service.
• karol mentioned this in D3498: [services] Dev Mode - Apply local cloud to the Backup service.
• karol mentioned this in D3523: [services] Backup/Blob - fix test path.
• karol added inline comments.Apr 11 2022, 6:49 AM
services/backup/docker-server/contents/run_tests.sh
5 ↗(On Diff #11284)

Ashoat's question about this: https://phabricator.ashoat.com/D3523#96086

For now, I'm not sure about this. If that's crucial, I can dig.

ashoat added inline comments.Apr 11 2022, 6:58 AM
services/backup/docker-server/contents/run_tests.sh
5 ↗(On Diff #11284)

I think you should always include information like this in a diff description. I certainly would

tomek requested changes to this revision.Apr 26 2022, 10:35 AM

Could you explain how it was broken and why these changes fix it?

This revision now requires changes to proceed.Apr 26 2022, 10:35 AM
• jim accepted this revision.Apr 26 2022, 10:42 AM
• karol updated this revision to Diff 11976.Apr 27 2022, 3:14 AM

remove unnecessary path fix, that has been taken care of in D3485

• karol added a comment.Apr 27 2022, 3:17 AM
In D3695#107153, @palys-swm wrote:

Could you explain how it was broken and why these changes fix it?

DatabaseSimulator has been removed (not sure in which commit exactly), so we don't want to use it if it doesn't exist.

services/backup/docker-server/contents/run_tests.sh
5 ↗(On Diff #11284)

I'm going to try to be better at this next time. For now this path fix is no longer relevant

Harbormaster completed remote builds in B8592: Diff 11976.Apr 27 2022, 3:19 AM
tomek accepted this revision.Apr 27 2022, 6:01 AM
This revision is now accepted and ready to land.Apr 27 2022, 6:01 AM
Closed by commit rCOMMac99b83189cf: [services] Dev mode - Fix Backup service (authored by • karol). · Explain WhyMay 6 2022, 1:46 AM
This revision was automatically updated to reflect the committed changes.
• karol added a commit: rCOMMac99b83189cf: [services] Dev mode - Fix Backup service.

Revision Contents
Changeset List

PathSize
services/
backup/
src/
8 lines

Diff 11976

View Options

services/backup/src/DatabaseManager.h

Loading...