Page MenuHomePhabricator
Differential D3700

[web] Add `tinycolor2` to `web/package.json`
ClosedPublic
Actions

Authored by atul on Apr 11 2022, 12:01 PM.
Tags
None
Referenced Files
F3488314: D3700.diff
Wed, Dec 18, 9:44 AM
Unknown Object (File)
Nov 17 2024, 2:29 AM
Unknown Object (File)
Nov 15 2024, 6:08 AM
Unknown Object (File)
Nov 15 2024, 6:08 AM
Unknown Object (File)
Nov 15 2024, 6:08 AM
Unknown Object (File)
Nov 15 2024, 6:08 AM
Unknown Object (File)
Nov 15 2024, 6:08 AM
Unknown Object (File)
Nov 5 2024, 8:58 PM
View All Files
Subscribers
• abosh
• adrian
ashoat
• benschac
• karol

Details

Reviewers
tomek
• jacek
ashoat
Commits
rCOMM207547893bef: [web] Add `tinycolor2` to `web/package.json`
Summary

So we can use tinycolor.equals(a, b) in ColorSelectorButton

Test Plan

Tested implicitly by D3701

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Apr 11 2022, 12:01 PM
Herald added subscribers: • abosh, • benschac, • karol and 2 others. · View Herald TranscriptApr 11 2022, 12:01 PM
atul added a reviewer: ashoat.Apr 11 2022, 12:12 PM

(adding @ashoat as a reviewer before first pass since I think it's rubber-stamp-able and it involves "dependencies")

Harbormaster completed remote builds in B8089: Diff 11314.Apr 11 2022, 12:13 PM
atul requested review of this revision.Apr 11 2022, 12:13 PM
atul edited the summary of this revision. (Show Details)Apr 11 2022, 12:14 PM
atul edited the test plan for this revision. (Show Details)
atul added a child revision: D3701: [web] Use `tinycolor.equals(a, b)` in `ColorSelectorButton`.
atul edited the summary of this revision. (Show Details)Apr 11 2022, 2:58 PM
atul added a parent revision: D3699: [web] Replace `ColorPicker` with `ColorSelector` in `ThreadSettingsModal`.
tomek accepted this revision.Apr 12 2022, 1:39 AM
tomek added 1 blocking reviewer(s): ashoat.
tomek added inline comments.
web/package.json
78

We're already using the same version on native so it should be fine

atul edited the summary of this revision. (Show Details)Apr 12 2022, 12:31 PM
atul removed a parent revision: D3699: [web] Replace `ColorPicker` with `ColorSelector` in `ThreadSettingsModal`.
ashoat accepted this revision.Apr 13 2022, 10:58 AM
This revision is now accepted and ready to land.Apr 13 2022, 10:58 AM
atul updated this revision to Diff 11440.Apr 13 2022, 11:00 AM
atul edited the summary of this revision. (Show Details)

rebase before landing

This revision was landed with ongoing or failed builds.Apr 13 2022, 11:00 AM
Closed by commit rCOMM207547893bef: [web] Add `tinycolor2` to `web/package.json` (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM207547893bef: [web] Add `tinycolor2` to `web/package.json`.
Harbormaster failed remote builds in B8173: Diff 11440!Apr 13 2022, 11:06 AM

Revision Contents
Changeset List

PathSize
web/
1 line

Diff 11314

View Options

web/package.json

Loading...