Page MenuHomePhabricator

[web] Add `tinycolor2` to `web/package.json`
ClosedPublic

Authored by atul on Apr 11 2022, 12:01 PM.
Tags
None
Referenced Files
F3494135: D3700.id11441.diff
Thu, Dec 19, 4:25 AM
F3494134: D3700.id11440.diff
Thu, Dec 19, 4:25 AM
F3494133: D3700.id11314.diff
Thu, Dec 19, 4:25 AM
F3494107: D3700.id.diff
Thu, Dec 19, 4:24 AM
F3494086: D3700.diff
Thu, Dec 19, 4:21 AM
F3489718: D3700.id11314.diff
Wed, Dec 18, 1:27 PM
F3489668: D3700.id11440.diff
Wed, Dec 18, 1:19 PM
F3488314: D3700.diff
Wed, Dec 18, 9:44 AM

Details

Summary

So we can use tinycolor.equals(a, b) in ColorSelectorButton

Test Plan

Tested implicitly by D3701

Diff Detail

Repository
rCOMM Comm
Branch
landapril13 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

(adding @ashoat as a reviewer before first pass since I think it's rubber-stamp-able and it involves "dependencies")

atul requested review of this revision.Apr 11 2022, 12:13 PM
atul edited the test plan for this revision. (Show Details)
tomek added 1 blocking reviewer(s): ashoat.
tomek added inline comments.
web/package.json
78 ↗(On Diff #11314)

We're already using the same version on native so it should be fine

This revision is now accepted and ready to land.Apr 13 2022, 10:58 AM
atul edited the summary of this revision. (Show Details)

rebase before landing

This revision was landed with ongoing or failed builds.Apr 13 2022, 11:00 AM
This revision was automatically updated to reflect the committed changes.