[web] Use `flex-wrap` to lay out `ColorSelectorButton`s in `ColorSelector`
ClosedPublic
Actions

Authored by atul on Apr 11 2022, 1:35 PM.

Details

Reviewers

• jacek
tomek

Commits

rCOMM871da6be31fa: [web] Use `flex-wrap` to lay out `ColorSelectorButton`s in `ColorSelector`

Summary

Addresses feedback from @palys-swm and @def-au1t in D3662. It turned out to be way easier than I expected (if I did it right...)

Depends on D3702

Test Plan

Layout looks correct at different zoom levels:

(the background colors are just to help visualize)

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Apr 11 2022, 1:35 PM

Herald added subscribers: • abosh, • benschac, • karol and 2 others. · View Herald TranscriptApr 11 2022, 1:35 PM

atul edited the test plan for this revision. (Show Details)Apr 11 2022, 1:36 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Apr 11 2022, 1:43 PM

Harbormaster failed remote builds in B8095: Diff 11322!

Harbormaster completed remote builds in B8095: Diff 11322.Apr 11 2022, 2:00 PM

atul requested review of this revision.Apr 11 2022, 2:00 PM

atul edited the summary of this revision. (Show Details)Apr 11 2022, 2:59 PM

atul added a parent revision: D3702: [web] Pull colors in `ColorSelector` from `selectedThreadColors`.

atul added a child revision: D3704: [web] Create `ColorSelectorButton`s in `ColorSelector` iteratively to reduce repetition.

Looks great

This revision is now accepted and ready to land.Apr 12 2022, 3:33 AM

rebase before landing

Harbormaster completed remote builds in B8133: Diff 11367.Apr 12 2022, 11:57 AM

Closed by commit rCOMM871da6be31fa: [web] Use `flex-wrap` to lay out `ColorSelectorButton`s in `ColorSelector` (authored by atul). · Explain WhyApr 12 2022, 12:00 PM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM871da6be31fa: [web] Use `flex-wrap` to lay out `ColorSelectorButton`s in `ColorSelector`.

Revision Contents
Changeset List

Path

Size

web/

modals/

threads/

color-selector.css

11 lines

color-selector.react.js

104 lines

Diff 11368

View Options

web/modals/threads/color-selector.css